From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH python-tests] gnu: python-2.7: Enable UCS-4 Unicode
	encoding.
Date: Mon, 23 Jan 2017 23:41:32 +0100
Message-ID: <87r33tl7qb.fsf@gnu.org>
References: <20170122233159.2622-1-dannym@scratchpost.org>
	<87sho968o5.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54028)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cVnIx-0007ya-R1
	for guix-devel@gnu.org; Mon, 23 Jan 2017 17:41:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cVnIt-0006IW-AC
	for guix-devel@gnu.org; Mon, 23 Jan 2017 17:41:38 -0500
In-Reply-To: <87sho968o5.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me>
	(Marius Bakke's message of "Mon, 23 Jan 2017 17:30:18 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel@gnu.org

Marius Bakke <mbakke@fastmail.com> skribis:

> Danny Milosavljevic <dannym@scratchpost.org> writes:
>
>> * gnu/packages/python.scm (python-2.7)[arguments]: Modify.
>> ---
>>  gnu/packages/python.scm | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
>> index fd423d311..6caaeaaf8 100644
>> --- a/gnu/packages/python.scm
>> +++ b/gnu/packages/python.scm
>> @@ -170,6 +170,7 @@
>>         (list "--enable-shared"                    ;allow embedding
>>               "--with-system-ffi"                  ;build ctypes
>>               "--with-ensurepip=3Dinstall"           ;install pip and se=
tuptools
>> +             "--enable-unicode=3Ducs4"
>>               (string-append "LDFLAGS=3D-Wl,-rpath=3D"
>>                              (assoc-ref %outputs "out") "/lib"))
>>=20=20
>
> Hi Danny,
>
> Can you push this to 'core-updates' instead?
>
> It will cause a rebuild of more than 2000 packages on 'python-tests' and
> invalidate almost all substitutes, and I would like to merge it sooner
> rather than later.
>
> Otherwise LGTM. I checked some other distros and they seem to have this
> enabled. Thanks!

That means that strings are internally UCS-4-encoded, right?  What=E2=80=99=
s the
rationale, and what happens when this flag is omitted?

(I=E2=80=99m not objecting to the patch, just trying to educate myself.  :-=
))

Ludo=E2=80=99.