From: ludo@gnu.org (Ludovic Courtès)
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH python-tests] gnu: python-2.7: Enable UCS-4 Unicode encoding.
Date: Mon, 23 Jan 2017 23:41:32 +0100 [thread overview]
Message-ID: <87r33tl7qb.fsf@gnu.org> (raw)
In-Reply-To: <87sho968o5.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> (Marius Bakke's message of "Mon, 23 Jan 2017 17:30:18 +0100")
Marius Bakke <mbakke@fastmail.com> skribis:
> Danny Milosavljevic <dannym@scratchpost.org> writes:
>
>> * gnu/packages/python.scm (python-2.7)[arguments]: Modify.
>> ---
>> gnu/packages/python.scm | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
>> index fd423d311..6caaeaaf8 100644
>> --- a/gnu/packages/python.scm
>> +++ b/gnu/packages/python.scm
>> @@ -170,6 +170,7 @@
>> (list "--enable-shared" ;allow embedding
>> "--with-system-ffi" ;build ctypes
>> "--with-ensurepip=install" ;install pip and setuptools
>> + "--enable-unicode=ucs4"
>> (string-append "LDFLAGS=-Wl,-rpath="
>> (assoc-ref %outputs "out") "/lib"))
>>
>
> Hi Danny,
>
> Can you push this to 'core-updates' instead?
>
> It will cause a rebuild of more than 2000 packages on 'python-tests' and
> invalidate almost all substitutes, and I would like to merge it sooner
> rather than later.
>
> Otherwise LGTM. I checked some other distros and they seem to have this
> enabled. Thanks!
That means that strings are internally UCS-4-encoded, right? What’s the
rationale, and what happens when this flag is omitted?
(I’m not objecting to the patch, just trying to educate myself. :-))
Ludo’.
next prev parent reply other threads:[~2017-01-23 22:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-22 23:31 [PATCH python-tests] gnu: python-2.7: Enable UCS-4 Unicode encoding Danny Milosavljevic
2017-01-23 3:55 ` Maxim Cournoyer
2017-01-23 16:30 ` Marius Bakke
2017-01-23 22:41 ` Ludovic Courtès [this message]
2017-01-23 23:46 ` Danny Milosavljevic
2017-01-24 8:27 ` Hartmut Goebel
2017-01-24 21:08 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r33tl7qb.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).