From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: [PATCH 4/6] gnu: Add lua5.2-bitop.
Date: Wed, 25 Jan 2017 10:17:21 +0100
Message-ID: <87r33r5wim.fsf@elephly.net>
References: <20170124144015.24473-1-ricardo.wurmus@mdc-berlin.de>
	<20170124144015.24473-4-ricardo.wurmus@mdc-berlin.de>
	<20170124185237.GB23492@jasmine>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46375)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1cWJiE-0004yG-Tu
	for guix-devel@gnu.org; Wed, 25 Jan 2017 04:17:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1cWJiB-0003qn-PN
	for guix-devel@gnu.org; Wed, 25 Jan 2017 04:17:54 -0500
Received: from sender163-mail.zoho.com ([74.201.84.163]:21041)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <rekado@elephly.net>) id 1cWJiB-0003qZ-Fq
	for guix-devel@gnu.org; Wed, 25 Jan 2017 04:17:51 -0500
In-reply-to: <20170124185237.GB23492@jasmine>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org


Leo Famulari <leo@famulari.name> writes:

> On Tue, Jan 24, 2017 at 03:40:13PM +0100, Ricardo Wurmus wrote:
>> * gnu/packages/lua.scm (lua5.2-bitop): New variable.
>
>> +    (arguments
>> +     `(#:test-target "test"
>> +       #:make-flags
>> +       (list "INSTALL=install -pD"
>> +             (string-append "INSTALLPATH=printf "
>
> What's up with this "printf"? Does it actually execute the value of
> INSTALLPATH?

INSTALLPATH defaults to “lua somefile.lua”, and it is applied to the
name of the module (“bit”).  If I just changed INSTALLPATH to a literal
path, the “install” target would try to execute it with “bit” as an
argument.

This is why I’m using “printf”, which when given a string literal
ignores any other arguments.  The result is just the install path.  I
chose this method over patching the Makefile.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net