unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 4/6] gnu: Add lua5.2-bitop.
Date: Wed, 25 Jan 2017 10:17:21 +0100	[thread overview]
Message-ID: <87r33r5wim.fsf@elephly.net> (raw)
In-Reply-To: <20170124185237.GB23492@jasmine>


Leo Famulari <leo@famulari.name> writes:

> On Tue, Jan 24, 2017 at 03:40:13PM +0100, Ricardo Wurmus wrote:
>> * gnu/packages/lua.scm (lua5.2-bitop): New variable.
>
>> +    (arguments
>> +     `(#:test-target "test"
>> +       #:make-flags
>> +       (list "INSTALL=install -pD"
>> +             (string-append "INSTALLPATH=printf "
>
> What's up with this "printf"? Does it actually execute the value of
> INSTALLPATH?

INSTALLPATH defaults to “lua somefile.lua”, and it is applied to the
name of the module (“bit”).  If I just changed INSTALLPATH to a literal
path, the “install” target would try to execute it with “bit” as an
argument.

This is why I’m using “printf”, which when given a string literal
ignores any other arguments.  The result is just the install path.  I
chose this method over patching the Makefile.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

  reply	other threads:[~2017-01-25  9:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-24 14:40 [PATCH 1/6] gnu: Add libmpack Ricardo Wurmus
2017-01-24 14:40 ` [PATCH 2/6] gnu: Add lua-libmpack Ricardo Wurmus
2017-01-24 18:51   ` Leo Famulari
2017-01-25  9:18     ` Ricardo Wurmus
2017-01-24 14:40 ` [PATCH 3/6] gnu: Add lua5.2-libmpack Ricardo Wurmus
2017-01-24 14:40 ` [PATCH 4/6] gnu: Add lua5.2-bitop Ricardo Wurmus
2017-01-24 18:52   ` Leo Famulari
2017-01-25  9:17     ` Ricardo Wurmus [this message]
2017-01-24 14:40 ` [PATCH 5/6] gnu: Add lua5.2-lpeg Ricardo Wurmus
2017-01-26 18:01   ` Ludovic Courtès
2017-01-31 19:41     ` Ricardo Wurmus
2017-01-24 14:40 ` [PATCH 6/6] gnu: Add neovim Ricardo Wurmus
2017-01-24 21:31   ` Ludovic Courtès
2017-01-31 20:04     ` Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r33r5wim.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=guix-devel@gnu.org \
    --cc=leo@famulari.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).