From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 1/2] gnu: Add openvswitch.
Date: Sun, 29 Jan 2017 00:56:06 +0100
Message-ID: <87r33myc15.fsf@gnu.org>
References: <20170127135616.15017-1-iyzsong@member.fsf.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34671)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cXcqq-000269-GH
	for guix-devel@gnu.org; Sat, 28 Jan 2017 18:56:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cXcqn-0003qP-FK
	for guix-devel@gnu.org; Sat, 28 Jan 2017 18:56:12 -0500
In-Reply-To: <20170127135616.15017-1-iyzsong@member.fsf.org>
	(=?utf-8?B?IuWui+aWh+atpiIncw==?=
	message of "Fri, 27 Jan 2017 21:56:15 +0800")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@member.fsf.org>
Cc: guix-devel@gnu.org

Hi =E5=AE=8B=E6=96=87=E6=AD=A6!

=E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@member.fsf.org> skribis:

> * gnu/packages/networking.scm (openvswitch): New variable.

[...]

> +     '(;; FIXME: many tests fail with:
> +       ;;    [=E2=80=A6]
> +       ;;    test -e $OVS_RUNDIR/ovs-vswitchd.pid
> +       ;;    ovs-appctl -t ovs-vswitchd exit
> +       ;;    hard failure
> +       #:tests? #f

Can we assume that the failures are due to the lack of a proper
networking environment?  Do they pass outside of the chroot?

It would be good to have a rough idea of why they fail.

> +         (replace 'install
> +           (lambda _
> +             (zero? (system* "make"
> +                             "RUNDIR=3D/tmp"
> +                             "PKIDIR=3D/tmp"
> +                             "LOGDIR=3D/tmp"
> +                             "DBDIR=3D/tmp"
> +                             "install")))))))

I suppose this is to prevent =E2=80=9Cmkdir /var/log=E2=80=9D or similar, r=
ight?
Perhaps worth mentioning in a comment.

The rest LGTM.

Thanks!

Ludo=E2=80=99.