unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Kei Kebreau <kei@openmailbox.org>
To: ng0 <contact.ng0@cryptolab.net>
Cc: guix-devel@gnu.org
Subject: Re: imgcat, v2.
Date: Sun, 29 Jan 2017 19:47:20 -0500	[thread overview]
Message-ID: <87r33ll6g7.fsf@openmailbox.org> (raw)
In-Reply-To: <87poj5czvs.fsf@wasp.i-did-not-set--mail-host-address--so-tickle-me> (ng0's message of "Sun, 29 Jan 2017 21:36:23 +0000")

[-- Attachment #1: Type: text/plain, Size: 646 bytes --]

ng0 <contact.ng0@cryptolab.net> writes:

> contact.ng0@cryptolab.net writes:
>
>> Fixed name in commit, edited the comments to clarify the not-obvious phases.
>>
>>
>
> If the dependency on imagemagick is undesired, I can split it off
> into two packages.
> The C program doesn't need imagemagick, while the bash script
> does. The quality in how they generate images differs according
> to the upstream README.

This patch looks good to me. According to the README the script produces
higher quality images, so we can keep the dependency on imagemagick.
Pushed to master as 9016dbc2bb469c31915c46cf8a1baecdfe022373. Thanks for
the cool package!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

      reply	other threads:[~2017-01-30  0:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-19 17:50 Add: imgcat contact.ng0
2017-01-19 17:50 ` [PATCH] gnu: Add imgcat contact.ng0
2017-01-29 19:19   ` Kei Kebreau
2017-01-29 21:14     ` ng0
2017-01-29 21:32       ` imgcat, v2 contact.ng0
2017-01-29 21:32         ` [PATCH] gnu: Add catimg contact.ng0
2017-01-29 21:36         ` imgcat, v2 ng0
2017-01-30  0:47           ` Kei Kebreau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r33ll6g7.fsf@openmailbox.org \
    --to=kei@openmailbox.org \
    --cc=contact.ng0@cryptolab.net \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).