From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxim Cournoyer Subject: Re: [PATCH 2/2] gnu: Add python-lzo. Date: Sun, 05 Feb 2017 01:31:18 -0800 Message-ID: <87r33d7zmh.fsf@gmail.com> References: <20170202151605.27876-1-contact.ng0@cryptolab.net> <20170202151605.27876-3-contact.ng0@cryptolab.net> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33562) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1caJAR-0006M7-F5 for guix-devel@gnu.org; Sun, 05 Feb 2017 04:31:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1caJAQ-0007p1-9a for guix-devel@gnu.org; Sun, 05 Feb 2017 04:31:31 -0500 Received: from mail-pg0-x244.google.com ([2607:f8b0:400e:c05::244]:35641) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1caJAQ-0007oR-4A for guix-devel@gnu.org; Sun, 05 Feb 2017 04:31:30 -0500 Received: by mail-pg0-x244.google.com with SMTP id 204so6229030pge.2 for ; Sun, 05 Feb 2017 01:31:29 -0800 (PST) In-Reply-To: <20170202151605.27876-3-contact.ng0@cryptolab.net> (contact's message of "Thu, 2 Feb 2017 15:16:05 +0000") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: contact.ng0@cryptolab.net Cc: guix-devel@gnu.org, ng0 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi ng0, contact.ng0@cryptolab.net writes: > From: ng0 > > * gnu/packages/compression.scm (python-lzo): New variable. > > Co-authored-by: Danny Milosavljevic > --- > gnu/packages/compression.scm | 36 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 36 insertions(+) > > diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm > index 64518fb6b..2545c4517 100644 > --- a/gnu/packages/compression.scm > +++ b/gnu/packages/compression.scm > @@ -365,6 +365,42 @@ LZO is written in ANSI C. Both the source code and = the compressed data > format are designed to be portable across platforms.") > (license license:gpl2+))) >=20=20 > +(define-public python-lzo > + (package > + (name "python-lzo") > + (version "1.11") > + (source > + (origin > + (method url-fetch) > + (uri (pypi-uri "python-lzo" version)) > + (sha256 > + (base32 > + "11p3ifg14p086byhhin6azx5svlkg8dzw2b5abixik97xd6fm81q")))) > + (build-system python-build-system) > + (arguments > + `(#:test-target "check" > + #:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'patch-setuppy > + (lambda _ > + (substitute* "setup.py" > + (("include_dirs.append.*") > + (string-append "include_dirs.append(\"" > + (assoc-ref %build-inputs "lzo") "/include= /lzo" "\") > +")))))))) A bit hard to read/long line here. Maybe the various string components being appended could be aligned below the string-append call? Also, you could use single quotes for the Python code which might help to differentiate what is what. Is the guix linter happy? > + (inputs > + `(("lzo" ,lzo))) > + (home-page "https://github.com/jd-boyd/python-lzo") > + (synopsis "Python bindings for the LZO data compression library") > + (description > + "Python-LZO provides Python bindings for LZO, i.e. you can access > +the LZO library from your Python scripts thereby compressing ordinary > +Python strings.") > + (license license:gpl2+))) > + > +(define-public python2-lzo > + (package-with-python2 python-lzo)) > + > (define-public lzop > (package > (name "lzop") Otherwise these 2 patches LGTM! Maxim --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEJ9WGpPiQCFQyn/CfEmDkZILmNWIFAliW8OYACgkQEmDkZILm NWKMHA/6AiV+Z8hE7r1nUEsO/V2YskUVHDpmJu2npYySY9V/N97J+/2ZBpxGQzF3 aTPwkV5om21DIYzUuzmkisXDSS9alrouqAMOyMUtbd1tohcVw8exZMpGfsFeCjx8 CMVagV9Vs09+1X3ObeTR+9rW2IvgSMp00PDXCS8cvQA7ae2KUq0mafxQIyj1sex9 XGpgYrGcD6QTBLCmpZJ27ZABnwl3hYxOtO4CESYMwJSSSK7DUK/rzWfFCqo5/tY7 NJAAwzjh/L7uc9xNi3BNFT5YEu/bhGD/pLFxPrZTCG2jzhSp3SGMeFPsTsuOxyEg 2CizfDPidRoY4P8AoOVGeGaPuaGxxpkLrrPryuDyTAuQ/I4w4QMy16Cv6brkOe93 +UFZstfoj0CsKZK5SQmerLOJOXgqjUlL5RXXG7OyQhvMuHgHnu2FwK2Rt6XtnjzJ 2ZyIccdHYBNJozCXP46NsgEjyKKb8yJcaah8MIujA6/Ttftb6JckQMxGcmYV6XXw fY/0eMkvQHhxyQ2t1vyrIP5uDOyhj9fMDyCzktsLt1g7dkBmLQKYCpuPVliUrGg+ qkcogl7ijlc93P0IvAB1iTlK4O+fbL3Znk1UcCl/EOGQh70Q8g6ZxAbXOGb3+xZd g+JJY5LrDzOxfRn9c1s4jt99oKVxsc0vev8QDtSl0u9C3k3NF3Q= =CuMJ -----END PGP SIGNATURE----- --=-=-=--