Re: [PATCH 2/2] gnu: Add python-lzo.

[Maxim Cournoyer <maxim.cournoyer@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2381 bytes --]

Hi ng0,

contact.ng0@cryptolab.net writes:

> From: ng0 <ngillmann@runbox.com>
>
> * gnu/packages/compression.scm (python-lzo): New variable.
>
> Co-authored-by: Danny Milosavljevic <dannym@scratchpost.org>
> ---
>  gnu/packages/compression.scm | 36 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
>
> diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm
> index 64518fb6b..2545c4517 100644
> --- a/gnu/packages/compression.scm
> +++ b/gnu/packages/compression.scm
> @@ -365,6 +365,42 @@ LZO is written in ANSI C.  Both the source code and the compressed data
>  format are designed to be portable across platforms.")
>      (license license:gpl2+)))
>  
> +(define-public python-lzo
> +  (package
> +    (name "python-lzo")
> +    (version "1.11")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "python-lzo" version))
> +       (sha256
> +        (base32
> +         "11p3ifg14p086byhhin6azx5svlkg8dzw2b5abixik97xd6fm81q"))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:test-target "check"
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'patch-setuppy
> +           (lambda _
> +             (substitute* "setup.py"
> +               (("include_dirs.append.*")
> +                (string-append "include_dirs.append(\""
> +                               (assoc-ref %build-inputs "lzo") "/include/lzo" "\")
> +"))))))))

A bit hard to read/long line here. Maybe the various string components
being appended could be aligned below the string-append call? Also, you
could use single quotes for the Python code which might help to
differentiate what is what.

Is the guix linter happy?

> +    (inputs
> +     `(("lzo" ,lzo)))
> +    (home-page "https://github.com/jd-boyd/python-lzo")
> +    (synopsis "Python bindings for the LZO data compression library")
> +    (description
> +     "Python-LZO provides Python bindings for LZO, i.e. you can access
> +the LZO library from your Python scripts thereby compressing ordinary
> +Python strings.")
> +    (license license:gpl2+)))
> +
> +(define-public python2-lzo
> +  (package-with-python2 python-lzo))
> +
>  (define-public lzop
>    (package
>      (name "lzop")

Otherwise these 2 patches LGTM!

Maxim

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]