From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?Cl=C3=A9ment?= Lassieur Subject: Re: [PATCH 4/4] services: openssh: Add 'subsystems' option. Date: Tue, 07 Mar 2017 22:01:39 +0100 Message-ID: <87r3284x8s.fsf@lassieur.org> References: <20170219185431.zgn53ndcbpedrgo7@wasp> <20170220235355.29115-1-clement@lassieur.org> <20170220235355.29115-5-clement@lassieur.org> <20170302084448.2ff6ce96@scratchpost.org> <87fuivxukg.fsf@lassieur.org> <20170305145026.zgoayn46kvpz5ksy@abyayala> <20170307214959.16038114@scratchpost.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54540) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1clMEu-0002c7-ON for guix-devel@gnu.org; Tue, 07 Mar 2017 16:01:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1clMEp-0003B3-R6 for guix-devel@gnu.org; Tue, 07 Mar 2017 16:01:48 -0500 Received: from mail.lassieur.org ([83.152.10.219]:38508) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1clMEp-0003Ae-Gz for guix-devel@gnu.org; Tue, 07 Mar 2017 16:01:43 -0500 In-reply-to: <20170307214959.16038114@scratchpost.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Danny Milosavljevic Cc: guix-devel@gnu.org > Hi ng0, > > On Sun, 5 Mar 2017 14:50:26 +0000 > ng0 wrote: > >> What I take from the discussion is, all is good to go except for >> subsystems. I'm okay with reviewing subsystems as an individual patch >> later on. For me this works. Push the 3 patches, and send the subsyste= ms >> one later as a new discussion-bug. > > The 3 were pushed to master. > > Patch 4 not yet. So let's discuss. > > I have no preference for pairs or lists - it's just that the > documentation should say what it actually expects - because the user > has to write the form differently: Hi Danny, I think there is a misunderstanding. I didn't want to push this because it was not tested, and because subsystems are often useless without Match, and Match is unsupported. The pair/list thing is not the problem. And I was waiting for ng0 to test, because he asked for this patch (see http://lists.gnu.org/archive/html/guix-devel/2017-02/msg00906.html), so I thought he was able to test. If ng0 still needs the patch and confirms that it works well, I'm willing to update it. Otherwise, let's drop it. Sorry for the confusion. Cl=C3=A9ment