From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: bug#26072: [PATCH 35/35] gnu: Add r-seurat. Date: Thu, 16 Mar 2017 14:07:39 +0100 Message-ID: <87r31xv084.fsf@elephly.net> References: <20170119185530.35824-1-ilpuccio.febo@gmail.com> <20170119185530.35824-35-ilpuccio.febo@gmail.com> <14cac63b-88fb-5edb-e8cc-87f515ba5881@uq.edu.au> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58872) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1coV8O-0004iN-RN for guix-devel@gnu.org; Thu, 16 Mar 2017 09:08:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1coV8K-0004OC-OL for guix-devel@gnu.org; Thu, 16 Mar 2017 09:08:04 -0400 Received: from sender-of-o51.zoho.com ([135.84.80.216]:21081) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1coV8K-0004Mb-H7 for guix-devel@gnu.org; Thu, 16 Mar 2017 09:08:00 -0400 In-reply-to: <14cac63b-88fb-5edb-e8cc-87f515ba5881@uq.edu.au> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ben Woodcroft Cc: guix-devel@gnu.org, 26072-done@debbugs.gnu.org > Seurat seems to have it's last release as v1.4.0, and the usual > approach would be to package that release. Is there some reason why a > specific commit was used? The latest version is 1.4.0.12, which appears to be 8 commits after the commit selected for this patch. The downloadable archive, however, does not contain the sources. The source archive for version 1.4.0 is from Oct 4, 2016. The selected commit probably was the latest version at the time. I’ll add a comment to the top of this package expression and update the commit to fccb77d, which is equivalent to the binary release 1.4.0.12. Thanks for the patches, and thank you Ben for the review! -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net