Re: 02/06: gnu: Add python-openid.

unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed

* Re: 02/06: gnu: Add python-openid.
       [not found] ` <20170408164141.90C48219E7@vcs0.savannah.gnu.org>
@ 2017-04-09  7:53   ` Mark H Weaver
  2017-04-10 22:52     ` Kei Kebreau
  0 siblings, 1 reply; 10+ messages in thread
From: Mark H Weaver @ 2017-04-09  7:53 UTC (permalink / raw)
  To: Kei Kebreau; +Cc: guix-devel

kei@openmailbox.org (Kei Kebreau) writes:

> kkebreau pushed a commit to branch master
> in repository guix.
>
> commit ccda56886625af84d34ebf1f26b22345e5dbe235
> Author: ng0 <ng0@libertad.pw>
> Date:   Wed Feb 15 10:09:23 2017 +0000
>
>     gnu: Add python-openid.
>     
>     * gnu/packages/python.scm (python-openid): New variable.
>     
>     Signed-off-by: Kei Kebreau <kei@openmailbox.org>

We already have 'python-openid'.  It's right above the one you just
added.  I reverted this commit.

Please be more careful.

    Thanks,
      Mark

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: 02/06: gnu: Add python-openid.
  2017-04-09  7:53   ` 02/06: gnu: Add python-openid Mark H Weaver
@ 2017-04-10 22:52     ` Kei Kebreau
  0 siblings, 0 replies; 10+ messages in thread
From: Kei Kebreau @ 2017-04-10 22:52 UTC (permalink / raw)
  To: Mark H Weaver; +Cc: guix-devel

[-- Attachment #1: Type: text/plain, Size: 777 bytes --]

Mark H Weaver <mhw@netris.org> writes:

> kei@openmailbox.org (Kei Kebreau) writes:
>
>> kkebreau pushed a commit to branch master
>> in repository guix.
>>
>> commit ccda56886625af84d34ebf1f26b22345e5dbe235
>> Author: ng0 <ng0@libertad.pw>
>> Date:   Wed Feb 15 10:09:23 2017 +0000
>>
>>     gnu: Add python-openid.
>>     
>>     * gnu/packages/python.scm (python-openid): New variable.
>>     
>>     Signed-off-by: Kei Kebreau <kei@openmailbox.org>
>
> We already have 'python-openid'.  It's right above the one you just
> added.  I reverted this commit.
>
> Please be more careful.
>
>     Thanks,
>       Mark

Aw, man. :-(

The really sad part is that I remember spotting this when I tested this
patch a few weeks ago. Your advice is noted.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

[parent not found: <20170408164141.E7604219E7@vcs0.savannah.gnu.org>]

* Re: 04/06: gnu: Add python-django-gravatar2.
       [not found] ` <20170408164141.E7604219E7@vcs0.savannah.gnu.org>
@ 2017-04-09  8:04   ` Mark H Weaver
  2017-04-09  8:20     ` Julien Lepiller
  0 siblings, 1 reply; 10+ messages in thread
From: Mark H Weaver @ 2017-04-09  8:04 UTC (permalink / raw)
  To: ng0, Kei Kebreau; +Cc: guix-devel

kei@openmailbox.org (Kei Kebreau) writes:

> kkebreau pushed a commit to branch master
> in repository guix.
>
> commit 14d8f6538f3af04c2bc879837f94f0bc54177aed
> Author: ng0 <ng0@libertad.pw>
> Date:   Wed Feb 15 10:09:25 2017 +0000
>
>     gnu: Add python-django-gravatar2.
>     
>     * gnu/packages/django.scm (python-django-gravatar2): New variable.
>     
>     Signed-off-by: Kei Kebreau <kei@openmailbox.org>

python-django-gravatar2 fails to build on Hydra:

  https://hydra.gnu.org/build/1974931  (x86_64-linux)
  https://hydra.gnu.org/build/1974902  (i686-linux)

The python2-* variants build successfully.

      Mark

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: 04/06: gnu: Add python-django-gravatar2.
  2017-04-09  8:04   ` 04/06: gnu: Add python-django-gravatar2 Mark H Weaver
@ 2017-04-09  8:20     ` Julien Lepiller
  2017-04-09  9:15       ` ng0
  2017-04-11  2:17       ` Kei Kebreau
  0 siblings, 2 replies; 10+ messages in thread
From: Julien Lepiller @ 2017-04-09  8:20 UTC (permalink / raw)
  To: guix-devel

On Sun, 09 Apr 2017 04:04:34 -0400
Mark H Weaver <mhw@netris.org> wrote:

> kei@openmailbox.org (Kei Kebreau) writes:
> 
> > kkebreau pushed a commit to branch master
> > in repository guix.
> >
> > commit 14d8f6538f3af04c2bc879837f94f0bc54177aed
> > Author: ng0 <ng0@libertad.pw>
> > Date:   Wed Feb 15 10:09:25 2017 +0000
> >
> >     gnu: Add python-django-gravatar2.
> >     
> >     * gnu/packages/django.scm (python-django-gravatar2): New
> > variable. 
> >     Signed-off-by: Kei Kebreau <kei@openmailbox.org>  
> 
> python-django-gravatar2 fails to build on Hydra:
> 
>   https://hydra.gnu.org/build/1974931  (x86_64-linux)
>   https://hydra.gnu.org/build/1974902  (i686-linux)
> 
> The python2-* variants build successfully.
> 
>       Mark
> 

I think the package alrady in master is mine, and it is not working
properly (I think it doesn't build anymore anyway). We should probably
replace it with ng0's. I will send a patch later today.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: 04/06: gnu: Add python-django-gravatar2.
  2017-04-09  8:20     ` Julien Lepiller
@ 2017-04-09  9:15       ` ng0
  2017-04-09 14:23         ` Julien Lepiller
  2017-04-11  2:17       ` Kei Kebreau
  1 sibling, 1 reply; 10+ messages in thread
From: ng0 @ 2017-04-09  9:15 UTC (permalink / raw)
  To: Julien Lepiller; +Cc: guix-devel

Julien Lepiller transcribed 0.9K bytes:
> On Sun, 09 Apr 2017 04:04:34 -0400
> Mark H Weaver <mhw@netris.org> wrote:
> 
> > kei@openmailbox.org (Kei Kebreau) writes:
> > 
> > > kkebreau pushed a commit to branch master
> > > in repository guix.
> > >
> > > commit 14d8f6538f3af04c2bc879837f94f0bc54177aed
> > > Author: ng0 <ng0@libertad.pw>
> > > Date:   Wed Feb 15 10:09:25 2017 +0000
> > >
> > >     gnu: Add python-django-gravatar2.
> > >     
> > >     * gnu/packages/django.scm (python-django-gravatar2): New
> > > variable. 
> > >     Signed-off-by: Kei Kebreau <kei@openmailbox.org>  
> > 
> > python-django-gravatar2 fails to build on Hydra:
> > 
> >   https://hydra.gnu.org/build/1974931  (x86_64-linux)
> >   https://hydra.gnu.org/build/1974902  (i686-linux)
> > 
> > The python2-* variants build successfully.
> > 
> >       Mark
> > 
> 
> I think the package alrady in master is mine, and it is not working
> properly (I think it doesn't build anymore anyway). We should probably
> replace it with ng0's. I will send a patch later today.
> 

I'm rather puzzled about django, and no one replied to the question
Harmut put up for discussion weeks ago.

There's this:
https://lists.gnu.org/archive/html/guix-devel/2017-02/msg00795.html

where I see Julien also added the python-openid I forgot to remove out
of my branch back then.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: 04/06: gnu: Add python-django-gravatar2.
  2017-04-09  9:15       ` ng0
@ 2017-04-09 14:23         ` Julien Lepiller
  0 siblings, 0 replies; 10+ messages in thread
From: Julien Lepiller @ 2017-04-09 14:23 UTC (permalink / raw)
  To: guix-devel

On Sun, 9 Apr 2017 09:15:41 +0000
ng0 <contact.ng0@cryptolab.net> wrote:

> Julien Lepiller transcribed 0.9K bytes:
> > On Sun, 09 Apr 2017 04:04:34 -0400
> > Mark H Weaver <mhw@netris.org> wrote:
> >   
> > > kei@openmailbox.org (Kei Kebreau) writes:
> > >   
> > > > kkebreau pushed a commit to branch master
> > > > in repository guix.
> > > >
> > > > commit 14d8f6538f3af04c2bc879837f94f0bc54177aed
> > > > Author: ng0 <ng0@libertad.pw>
> > > > Date:   Wed Feb 15 10:09:25 2017 +0000
> > > >
> > > >     gnu: Add python-django-gravatar2.
> > > >     
> > > >     * gnu/packages/django.scm (python-django-gravatar2): New
> > > > variable. 
> > > >     Signed-off-by: Kei Kebreau <kei@openmailbox.org>    
> > > 
> > > python-django-gravatar2 fails to build on Hydra:
> > > 
> > >   https://hydra.gnu.org/build/1974931  (x86_64-linux)
> > >   https://hydra.gnu.org/build/1974902  (i686-linux)
> > > 
> > > The python2-* variants build successfully.
> > > 
> > >       Mark
> > >   
> > 
> > I think the package alrady in master is mine, and it is not working
> > properly (I think it doesn't build anymore anyway). We should
> > probably replace it with ng0's. I will send a patch later today.
> >   
> 
> I'm rather puzzled about django, and no one replied to the question
> Harmut put up for discussion weeks ago.
> 
> There's this:
> https://lists.gnu.org/archive/html/guix-devel/2017-02/msg00795.html
> 
> where I see Julien also added the python-openid I forgot to remove out
> of my branch back then.

I replied to the wrong thread, I was talking about python-openid, not
django, sorry. Working on python-openid, I added the same dependencies
as in your patch, but I can't make it pass its tests. I get:

TypeError: __init__() missing 2 required positional arguments: 'desc'
and 'line'

Did you meet this before? I don't understand where it comes from.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: 04/06: gnu: Add python-django-gravatar2.
  2017-04-09  8:20     ` Julien Lepiller
  2017-04-09  9:15       ` ng0
@ 2017-04-11  2:17       ` Kei Kebreau
  1 sibling, 0 replies; 10+ messages in thread
From: Kei Kebreau @ 2017-04-11  2:17 UTC (permalink / raw)
  To: Mark H Weaver; +Cc: guix-devel

[-- Attachment #1: Type: text/plain, Size: 948 bytes --]

On Sun, 09 Apr 2017 04:04:34 -0400
Mark H Weaver <mhw@netris.org> wrote:
> kei@openmailbox.org (Kei Kebreau) writes:
> 
> > kkebreau pushed a commit to branch master
> > in repository guix.
> >
> > commit 14d8f6538f3af04c2bc879837f94f0bc54177aed
> > Author: ng0 <ng0@libertad.pw>
> > Date:   Wed Feb 15 10:09:25 2017 +0000
> >
> >     gnu: Add python-django-gravatar2.
> >     
> >     * gnu/packages/django.scm (python-django-gravatar2): New
> > variable. 
> >     Signed-off-by: Kei Kebreau <kei@openmailbox.org>  
> 
> python-django-gravatar2 fails to build on Hydra:
> 
>   https://hydra.gnu.org/build/1974931  (x86_64-linux)
>   https://hydra.gnu.org/build/1974902  (i686-linux)
> 
> The python2-* variants build successfully.
> 

This seems to be a test failure, but I believe that the tests can be
disabled. When testing python2-django-gravatar2 manually, the success
message reports running "0 tests in 0.000s."

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

[parent not found: <20170408164141.BC255219E7@vcs0.savannah.gnu.org>]

* Re: 03/06: gnu: Add python-django-allauth.
       [not found] ` <20170408164141.BC255219E7@vcs0.savannah.gnu.org>
@ 2017-04-09  8:15   ` Mark H Weaver
  2017-04-09  9:17     ` ng0
  2017-04-10 22:46     ` Kei Kebreau
  0 siblings, 2 replies; 10+ messages in thread
From: Mark H Weaver @ 2017-04-09  8:15 UTC (permalink / raw)
  To: ng0, Kei Kebreau; +Cc: guix-devel

kei@openmailbox.org (Kei Kebreau) writes:

> kkebreau pushed a commit to branch master
> in repository guix.
>
> commit e1f06e1192f57551bcb67d93411affb9d497e30c
> Author: ng0 <ng0@libertad.pw>
> Date:   Wed Feb 15 10:09:24 2017 +0000
>
>     gnu: Add python-django-allauth.
>     
>     * gnu/packages/django.scm (python-django-allauth): New variable.
>     
>     Signed-off-by: Kei Kebreau <kei@openmailbox.org>

Both variants of this package failed to build on Hydra.

'python-django-allauth' was a dependency failure, for failure to build
the duplicate 'python-openid' package that you added.

  https://hydra.gnu.org/build/1974947
  https://hydra.gnu.org/build/1974947/nixlog/1/raw

'python2-django-allauth' failed while apparently trying to download
python-openid.

  https://hydra.gnu.org/build/1974907

I'm concerned at the number of problems in this batch of commits.
Did these packages build successfully on your machine?

      Mark

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: 03/06: gnu: Add python-django-allauth.
  2017-04-09  8:15   ` 03/06: gnu: Add python-django-allauth Mark H Weaver
@ 2017-04-09  9:17     ` ng0
  2017-04-10 22:46     ` Kei Kebreau
  1 sibling, 0 replies; 10+ messages in thread
From: ng0 @ 2017-04-09  9:17 UTC (permalink / raw)
  To: Mark H Weaver; +Cc: guix-devel, ng0

Mark H Weaver transcribed 0.9K bytes:
> kei@openmailbox.org (Kei Kebreau) writes:
> 
> > kkebreau pushed a commit to branch master
> > in repository guix.
> >
> > commit e1f06e1192f57551bcb67d93411affb9d497e30c
> > Author: ng0 <ng0@libertad.pw>
> > Date:   Wed Feb 15 10:09:24 2017 +0000
> >
> >     gnu: Add python-django-allauth.
> >     
> >     * gnu/packages/django.scm (python-django-allauth): New variable.
> >     
> >     Signed-off-by: Kei Kebreau <kei@openmailbox.org>
> 
> Both variants of this package failed to build on Hydra.
> 
> 'python-django-allauth' was a dependency failure, for failure to build
> the duplicate 'python-openid' package that you added.
> 
>   https://hydra.gnu.org/build/1974947
>   https://hydra.gnu.org/build/1974947/nixlog/1/raw
> 
> 'python2-django-allauth' failed while apparently trying to download
> python-openid.
> 
>   https://hydra.gnu.org/build/1974907
> 
> I'm concerned at the number of problems in this batch of commits.
> Did these packages build successfully on your machine?
> 
>       Mark
> 

Yes. I also had Harmut review it first, and Harmut corrected all issues.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: 03/06: gnu: Add python-django-allauth.
  2017-04-09  8:15   ` 03/06: gnu: Add python-django-allauth Mark H Weaver
  2017-04-09  9:17     ` ng0
@ 2017-04-10 22:46     ` Kei Kebreau
  1 sibling, 0 replies; 10+ messages in thread
From: Kei Kebreau @ 2017-04-10 22:46 UTC (permalink / raw)
  To: Mark H Weaver; +Cc: guix-devel, ng0

[-- Attachment #1: Type: text/plain, Size: 1108 bytes --]

Mark H Weaver <mhw@netris.org> writes:

> kei@openmailbox.org (Kei Kebreau) writes:
>
>> kkebreau pushed a commit to branch master
>> in repository guix.
>>
>> commit e1f06e1192f57551bcb67d93411affb9d497e30c
>> Author: ng0 <ng0@libertad.pw>
>> Date:   Wed Feb 15 10:09:24 2017 +0000
>>
>>     gnu: Add python-django-allauth.
>>     
>>     * gnu/packages/django.scm (python-django-allauth): New variable.
>>     
>>     Signed-off-by: Kei Kebreau <kei@openmailbox.org>
>
> Both variants of this package failed to build on Hydra.
>
> 'python-django-allauth' was a dependency failure, for failure to build
> the duplicate 'python-openid' package that you added.
>
>   https://hydra.gnu.org/build/1974947
>   https://hydra.gnu.org/build/1974947/nixlog/1/raw
>
> 'python2-django-allauth' failed while apparently trying to download
> python-openid.
>
>   https://hydra.gnu.org/build/1974907
>
> I'm concerned at the number of problems in this batch of commits.
> Did these packages build successfully on your machine?
>
>       Mark

They did build successfully on my machine.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2017-04-11  2:18 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20170408164140.25323.26426@vcs0.savannah.gnu.org>
     [not found] ` <20170408164141.90C48219E7@vcs0.savannah.gnu.org>
2017-04-09  7:53   ` 02/06: gnu: Add python-openid Mark H Weaver
2017-04-10 22:52     ` Kei Kebreau
     [not found] ` <20170408164141.E7604219E7@vcs0.savannah.gnu.org>
2017-04-09  8:04   ` 04/06: gnu: Add python-django-gravatar2 Mark H Weaver
2017-04-09  8:20     ` Julien Lepiller
2017-04-09  9:15       ` ng0
2017-04-09 14:23         ` Julien Lepiller
2017-04-11  2:17       ` Kei Kebreau
     [not found] ` <20170408164141.BC255219E7@vcs0.savannah.gnu.org>
2017-04-09  8:15   ` 03/06: gnu: Add python-django-allauth Mark H Weaver
2017-04-09  9:17     ` ng0
2017-04-10 22:46     ` Kei Kebreau

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).