* Re: 01/01: gnu: qemu: Enable Samba support. [not found] ` <20171227092650.69D7B204F7@vcs0.savannah.gnu.org> @ 2017-12-27 12:04 ` Ludovic Courtès 2017-12-27 13:23 ` Rutger Helling 2017-12-27 22:53 ` Mark H Weaver 1 sibling, 1 reply; 7+ messages in thread From: Ludovic Courtès @ 2017-12-27 12:04 UTC (permalink / raw) To: guix-devel, Rutger Helling Hello, rhelling@mykolab.com (Rutger Helling) skribis: > commit 84276503059d46c0a42240f8770f59090614d863 > Author: Rutger Helling <rhelling@mykolab.com> > Date: Wed Dec 27 10:09:26 2017 +0100 > > gnu: qemu: Enable Samba support. > > * gnu/packages/virtualization.scm (qemu)[arguments]: Change #:configure-flags to > a list, add --smbd flag. > [inputs]: Add samba. [...] > + #:configure-flags (list "--enable-usb-redir" "--enable-opengl" > + (string-append "--smbd=" > + (assoc-ref %build-inputs "samba") > + "/sbin/smbd")) For the record, we removed the dependency on Samba long ago (commit b344c505f4dff2ecbe981f0a0a3c3d67b222dcca), largely because Samba is a huge dependency: --8<---------------cut here---------------start------------->8--- $ guix size qemu | tail -1 total: 817.4 MiB $ guix size qemu samba | tail -1 total: 1176.0 MiB --8<---------------cut here---------------end--------------->8--- As it stands I’d still be in favor of not having the default ‘qemu’ depend on Samba. Perhaps one solution would be to change the ‘exec’ call that invokes ‘smbd’ to ‘execlp’ (or similar) so that ‘smbd’ is search for in $PATH. That way, if the user installs Samba, then support is available, otherwise it’s missing. WDYT? Thanks, Ludo’. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: 01/01: gnu: qemu: Enable Samba support. 2017-12-27 12:04 ` 01/01: gnu: qemu: Enable Samba support Ludovic Courtès @ 2017-12-27 13:23 ` Rutger Helling 2017-12-27 20:59 ` Rutger Helling 0 siblings, 1 reply; 7+ messages in thread From: Rutger Helling @ 2017-12-27 13:23 UTC (permalink / raw) To: Ludovic Courtès; +Cc: guix-devel [-- Attachment #1: Type: text/plain, Size: 1869 bytes --] Sorry, I hadn't thought of that! I've reverted it for now. Would another option be to inherit to a new package? Something like qemu-full, where we could more easily turn on all the bells and whistles that Qemu has? On Wed, 27 Dec 2017 13:04:09 +0100 ludo@gnu.org (Ludovic Courtès) wrote: > Hello, > > rhelling@mykolab.com (Rutger Helling) skribis: > > > commit 84276503059d46c0a42240f8770f59090614d863 > > Author: Rutger Helling <rhelling@mykolab.com> > > Date: Wed Dec 27 10:09:26 2017 +0100 > > > > gnu: qemu: Enable Samba support. > > > > * gnu/packages/virtualization.scm (qemu)[arguments]: Change > > #:configure-flags to a list, add --smbd flag. > > [inputs]: Add samba. > > [...] > > > + #:configure-flags (list "--enable-usb-redir" > > "--enable-opengl" > > + (string-append "--smbd=" > > + (assoc-ref > > %build-inputs "samba") > > + "/sbin/smbd")) > > For the record, we removed the dependency on Samba long ago (commit > b344c505f4dff2ecbe981f0a0a3c3d67b222dcca), largely because Samba is a > huge dependency: > > --8<---------------cut here---------------start------------->8--- > $ guix size qemu | tail -1 > total: 817.4 MiB > $ guix size qemu samba | tail -1 > total: 1176.0 MiB > --8<---------------cut here---------------end--------------->8--- > > As it stands I’d still be in favor of not having the default ‘qemu’ > depend on Samba. > > Perhaps one solution would be to change the ‘exec’ call that invokes > ‘smbd’ to ‘execlp’ (or similar) so that ‘smbd’ is search for in $PATH. > That way, if the user installs Samba, then support is available, > otherwise it’s missing. > > WDYT? > > Thanks, > Ludo’. [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: 01/01: gnu: qemu: Enable Samba support. 2017-12-27 13:23 ` Rutger Helling @ 2017-12-27 20:59 ` Rutger Helling 0 siblings, 0 replies; 7+ messages in thread From: Rutger Helling @ 2017-12-27 20:59 UTC (permalink / raw) To: Ludovic Courtès; +Cc: guix-devel [-- Attachment #1: Type: text/plain, Size: 2374 bytes --] I've created a wrapper for Samba that seems to do the trick, with a big caveat. It doesn't error out when Samba is not actually available. I'd prefer adding Samba directely, but if that's not an option it's better than nothing. I'll send it in later this week after cleaning it up a bit. On Wed, 27 Dec 2017 14:23:31 +0100 Rutger Helling <rhelling@mykolab.com> wrote: > Sorry, I hadn't thought of that! I've reverted it for now. > > Would another option be to inherit to a new package? Something like > qemu-full, where we could more easily turn on all the bells and > whistles that Qemu has? > > On Wed, 27 Dec 2017 13:04:09 +0100 > ludo@gnu.org (Ludovic Courtès) wrote: > > > Hello, > > > > rhelling@mykolab.com (Rutger Helling) skribis: > > > > > commit 84276503059d46c0a42240f8770f59090614d863 > > > Author: Rutger Helling <rhelling@mykolab.com> > > > Date: Wed Dec 27 10:09:26 2017 +0100 > > > > > > gnu: qemu: Enable Samba support. > > > > > > * gnu/packages/virtualization.scm (qemu)[arguments]: Change > > > #:configure-flags to a list, add --smbd flag. > > > [inputs]: Add samba. > > > > [...] > > > > > + #:configure-flags (list "--enable-usb-redir" > > > "--enable-opengl" > > > + (string-append "--smbd=" > > > + (assoc-ref > > > %build-inputs "samba") > > > + "/sbin/smbd")) > > > > For the record, we removed the dependency on Samba long ago (commit > > b344c505f4dff2ecbe981f0a0a3c3d67b222dcca), largely because Samba is > > a huge dependency: > > > > --8<---------------cut here---------------start------------->8--- > > $ guix size qemu | tail -1 > > total: 817.4 MiB > > $ guix size qemu samba | tail -1 > > total: 1176.0 MiB > > --8<---------------cut here---------------end--------------->8--- > > > > As it stands I’d still be in favor of not having the default ‘qemu’ > > depend on Samba. > > > > Perhaps one solution would be to change the ‘exec’ call that invokes > > ‘smbd’ to ‘execlp’ (or similar) so that ‘smbd’ is search for in > > $PATH. That way, if the user installs Samba, then support is > > available, otherwise it’s missing. > > > > WDYT? > > > > Thanks, > > Ludo’. > [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: 01/01: gnu: qemu: Enable Samba support. [not found] ` <20171227092650.69D7B204F7@vcs0.savannah.gnu.org> 2017-12-27 12:04 ` 01/01: gnu: qemu: Enable Samba support Ludovic Courtès @ 2017-12-27 22:53 ` Mark H Weaver 2017-12-27 22:56 ` Rutger Helling 2017-12-27 23:41 ` Maxim Cournoyer 1 sibling, 2 replies; 7+ messages in thread From: Mark H Weaver @ 2017-12-27 22:53 UTC (permalink / raw) To: Rutger Helling; +Cc: guix-devel Hi, rhelling@mykolab.com (Rutger Helling) writes: > rhelling pushed a commit to branch master > in repository guix. > > commit 84276503059d46c0a42240f8770f59090614d863 > Author: Rutger Helling <rhelling@mykolab.com> > Date: Wed Dec 27 10:09:26 2017 +0100 > > gnu: qemu: Enable Samba support. > > * gnu/packages/virtualization.scm (qemu)[arguments]: Change #:configure-flags to > a list, add --smbd flag. > [inputs]: Add samba. I see that you have since reverted this commit, but I still thought I'd mention that when adding optional features to 'qemu', it would be good to remove them from 'qemu-minimal', which inherits from 'qemu'. Thanks, Mark ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: 01/01: gnu: qemu: Enable Samba support. 2017-12-27 22:53 ` Mark H Weaver @ 2017-12-27 22:56 ` Rutger Helling 2017-12-27 23:41 ` Maxim Cournoyer 1 sibling, 0 replies; 7+ messages in thread From: Rutger Helling @ 2017-12-27 22:56 UTC (permalink / raw) To: Mark H Weaver; +Cc: guix-devel [-- Attachment #1: Type: text/plain, Size: 892 bytes --] Thanks for the tip! I'll keep it in mind for the future. On Wed, 27 Dec 2017 17:53:19 -0500 Mark H Weaver <mhw@netris.org> wrote: > Hi, > > rhelling@mykolab.com (Rutger Helling) writes: > > > rhelling pushed a commit to branch master > > in repository guix. > > > > commit 84276503059d46c0a42240f8770f59090614d863 > > Author: Rutger Helling <rhelling@mykolab.com> > > Date: Wed Dec 27 10:09:26 2017 +0100 > > > > gnu: qemu: Enable Samba support. > > > > * gnu/packages/virtualization.scm (qemu)[arguments]: Change > > #:configure-flags to a list, add --smbd flag. > > [inputs]: Add samba. > > I see that you have since reverted this commit, but I still thought > I'd mention that when adding optional features to 'qemu', it would be > good to remove them from 'qemu-minimal', which inherits from 'qemu'. > > Thanks, > Mark [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: 01/01: gnu: qemu: Enable Samba support. 2017-12-27 22:53 ` Mark H Weaver 2017-12-27 22:56 ` Rutger Helling @ 2017-12-27 23:41 ` Maxim Cournoyer 2017-12-28 5:46 ` Rutger Helling 1 sibling, 1 reply; 7+ messages in thread From: Maxim Cournoyer @ 2017-12-27 23:41 UTC (permalink / raw) To: guix-devel, Mark H Weaver, rhelling Hello, On December 27, 2017 5:53:19 PM EST, Mark H Weaver <mhw@netris.org> wrote: >Hi, > >rhelling@mykolab.com (Rutger Helling) writes: > >> rhelling pushed a commit to branch master >> in repository guix. >> >> commit 84276503059d46c0a42240f8770f59090614d863 >> Author: Rutger Helling <rhelling@mykolab.com> >> Date: Wed Dec 27 10:09:26 2017 +0100 >> >> gnu: qemu: Enable Samba support. >> >> * gnu/packages/virtualization.scm (qemu)[arguments]: Change >#:configure-flags to >> a list, add --smbd flag. >> [inputs]: Add samba. > >I see that you have since reverted this commit, but I still thought I'd >mention that when adding optional features to 'qemu', it would be good >to remove them from 'qemu-minimal', which inherits from 'qemu'. Maybe this relationship could be turned around? It seems like it'd make more sense. Maxim ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: 01/01: gnu: qemu: Enable Samba support. 2017-12-27 23:41 ` Maxim Cournoyer @ 2017-12-28 5:46 ` Rutger Helling 0 siblings, 0 replies; 7+ messages in thread From: Rutger Helling @ 2017-12-28 5:46 UTC (permalink / raw) To: Maxim Cournoyer; +Cc: guix-devel [-- Attachment #1: Type: text/plain, Size: 1088 bytes --] That does seem more logical IMO. On Wed, 27 Dec 2017 23:41:31 +0000 Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote: > Hello, > > On December 27, 2017 5:53:19 PM EST, Mark H Weaver <mhw@netris.org> > wrote: > >Hi, > > > >rhelling@mykolab.com (Rutger Helling) writes: > > > >> rhelling pushed a commit to branch master > >> in repository guix. > >> > >> commit 84276503059d46c0a42240f8770f59090614d863 > >> Author: Rutger Helling <rhelling@mykolab.com> > >> Date: Wed Dec 27 10:09:26 2017 +0100 > >> > >> gnu: qemu: Enable Samba support. > >> > >> * gnu/packages/virtualization.scm (qemu)[arguments]: Change > >#:configure-flags to > >> a list, add --smbd flag. > >> [inputs]: Add samba. > > > >I see that you have since reverted this commit, but I still thought > >I'd mention that when adding optional features to 'qemu', it would > >be good to remove them from 'qemu-minimal', which inherits from > >'qemu'. > > Maybe this relationship could be turned around? It seems like it'd > make more sense. > > Maxim [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-12-28 5:46 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <20171227092649.22335.79799@vcs0.savannah.gnu.org> [not found] ` <20171227092650.69D7B204F7@vcs0.savannah.gnu.org> 2017-12-27 12:04 ` 01/01: gnu: qemu: Enable Samba support Ludovic Courtès 2017-12-27 13:23 ` Rutger Helling 2017-12-27 20:59 ` Rutger Helling 2017-12-27 22:53 ` Mark H Weaver 2017-12-27 22:56 ` Rutger Helling 2017-12-27 23:41 ` Maxim Cournoyer 2017-12-28 5:46 ` Rutger Helling
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/guix.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).