From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark H Weaver <mhw@netris.org>
Subject: Re: 01/01: gnu: qemu: Enable Samba support.
Date: Wed, 27 Dec 2017 17:53:19 -0500
Message-ID: <87r2rfn5pc.fsf@netris.org>
References: <20171227092649.22335.79799@vcs0.savannah.gnu.org>
	<20171227092650.69D7B204F7@vcs0.savannah.gnu.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56039)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1eUKa4-00033o-W8
	for guix-devel@gnu.org; Wed, 27 Dec 2017 17:53:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1eUKa1-00023d-Sp
	for guix-devel@gnu.org; Wed, 27 Dec 2017 17:53:49 -0500
Received: from world.peace.net ([50.252.239.5]:60210)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mhw@netris.org>) id 1eUKa1-000230-L8
	for guix-devel@gnu.org; Wed, 27 Dec 2017 17:53:45 -0500
In-Reply-To: <20171227092650.69D7B204F7@vcs0.savannah.gnu.org> (Rutger
	Helling's message of "Wed, 27 Dec 2017 04:26:50 -0500 (EST)")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Rutger Helling <rhelling@mykolab.com>
Cc: guix-devel@gnu.org

Hi,

rhelling@mykolab.com (Rutger Helling) writes:

> rhelling pushed a commit to branch master
> in repository guix.
>
> commit 84276503059d46c0a42240f8770f59090614d863
> Author: Rutger Helling <rhelling@mykolab.com>
> Date:   Wed Dec 27 10:09:26 2017 +0100
>
>     gnu: qemu: Enable Samba support.
>     
>     * gnu/packages/virtualization.scm (qemu)[arguments]: Change #:configure-flags to
>     a list, add --smbd flag.
>     [inputs]: Add samba.

I see that you have since reverted this commit, but I still thought I'd
mention that when adding optional features to 'qemu', it would be good
to remove them from 'qemu-minimal', which inherits from 'qemu'.

     Thanks,
       Mark