From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Marusich Subject: Re: shortening the git test suite Date: Thu, 05 Jul 2018 01:44:23 -0700 Message-ID: <87r2ki2hso.fsf@gmail.com> References: <87r2ko6pby.fsf@elephly.net> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37573) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fazsN-0000u2-Db for guix-devel@gnu.org; Thu, 05 Jul 2018 04:44:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fazsM-0005oX-8W for guix-devel@gnu.org; Thu, 05 Jul 2018 04:44:31 -0400 Received: from mail-pl0-x229.google.com ([2607:f8b0:400e:c01::229]:39260) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fazsM-0005nJ-2I for guix-devel@gnu.org; Thu, 05 Jul 2018 04:44:30 -0400 Received: by mail-pl0-x229.google.com with SMTP id s24-v6so922291plq.6 for ; Thu, 05 Jul 2018 01:44:29 -0700 (PDT) In-Reply-To: <87r2ko6pby.fsf@elephly.net> (Ricardo Wurmus's message of "Sat, 30 Jun 2018 21:34:25 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Ricardo Wurmus writes: > Hi Guix, > > git takes a very long time to build, because it has an extensive test > suite. Most of the time is spent in running the SVN interoperability > tests, though, which are not really all that interesting for most uses > of git. > > The Makefile says this: > > # Define NO_SVN_TESTS if you want to skip time-consuming SVN interopera= bility > # tests. These tests take up a significant amount of the total test ti= me > # but are not needed unless you plan to talk to SVN repos. > > What do you think about disabling the SVN tests in the git package? This sounds similar to the discussion we had earlier about treating tests as a special case: https://lists.gnu.org/archive/html/guix-devel/2018-04/msg00071.html I felt that the conclusion of that thread was basically that if someone is concerned about the build time, then they ought to be able to use substitutes to speed things up, and we should continue to run as many tests as possible in order to discover problems sooner. I'm in favor of disabling tests if they fail for reasons other than bugs in the program and there isn't an easy fix (e.g., they require root privileges, or they fail due to randomness in the tests), but disabling them simply because they take a "long" time doesn't seem like a great reason, to me. I'm sympathetic, since I don't like waiting around, either, but substitutes should be sufficient for those who need faster builds. =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAls92mcACgkQ3UCaFdgi Rp0b9g/+NbqaxhKtGHK0jsncrbHPIZxe0XHJVbwQ4L5ZPSq3ljejGEuevhTAmAnv sSPRvpYoCYgzvqPwEayJxUp0NN3kArqEbIUAPuPGpCvPHICSRmw25uk27TLsQQ/a bLirVaY9RXyt/YW4SIkW4pD8wO2tcuZ2J9pVfvnQy/c6A8k+v0r7+l0yWi5Fu9Tu DJQquDgYFU9CcvmNm31PcTFbh57WiY7GeAtNig0/3r5+AhIpgDnnRwck9kI/bynN R1yELR6QDSUjEeaaXU+Jf7JR7IEnafI1sEUTryyD+vRWNJ6K3DnPw2NhEKNh7X/r KDoeRs8aTvW2QMfUmhTxk1Efp5jcLm/DeV8eYhQ/5o8FkXTk7Xe0TOHtAZAsG8iW 1843vmrKe/bGEK/l5Bw8SQ1x+spBnLOhTlJNulmsL7UMutTapeSE7Qrn1gXFXPTI dhKATKpaKbyzhp/s4ewkAYbvv7cZZEl9bvxkdqBPP0hc4kY/DEYU5oIQHYnWTlrb q7iPhbOBOYNwYXAh3Z6R+ZrufrMJpJUYYn6FJHPWE/5rR8ty9I4wzPoqPVTvcCzu 6BGBt4enIIPJiQZqZ+28Y8N5SAUTSkhNdyKDT+h50JVI9yK6gDIv2R5Z7uD+AzbR 0IhIyNtWZA44vRrt6sX7w35h+vsbXO1kYOGyUme8WOzyj2P292M= =DCj9 -----END PGP SIGNATURE----- --=-=-=--