From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?Q?Cl=C3=A9ment?= Lassieur <clement@lassieur.org>
Subject: Web interface pushed
Date: Mon, 30 Jul 2018 00:08:20 +0200
Message-ID: <87r2jlbsq3.fsf@lassieur.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39296)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <clement@lassieur.org>) id 1fjtrZ-0005x0-PY
	for guix-devel@gnu.org; Sun, 29 Jul 2018 18:08:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <clement@lassieur.org>) id 1fjtrW-0002b7-JA
	for guix-devel@gnu.org; Sun, 29 Jul 2018 18:08:29 -0400
Received: from mail.lassieur.org ([83.152.10.219]:60876)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <clement@lassieur.org>)
	id 1fjtrW-0002aF-80
	for guix-devel@gnu.org; Sun, 29 Jul 2018 18:08:26 -0400
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Tatiana Sholokhova <tanja201396@gmail.com>
Cc: Guix-devel <guix-devel@gnu.org>

Hi Tatiana,

So, I did the pagination review and I pushed your work tonight.  :-)

I added checks to avoid crashes when the table is empty (FIRST and LAST
expect non-empty lists).

I modified a few minor things too:

- the commit message, so that it matches our convention
- the indentation
- I removed code comments, trailing '\' in SQL queries, useless
  newlines, useless exports
- I renamed a few things (e.g. thing-list with things, %pagesize with
  %page-size)
- I replaced (+ 1 x) with (1+ x)
- I used string-join to avoid long strings
- I used FIRST instead of CAR when used with LAST (for more consistency,
  but it's the exact same thing)
- I replaced FIRST and LAST with BUILD-ID and BUILD-STOPTIME, so to make
  it more furure-proof and easier to understand
- I used a format string for RESPOND-HTML (to avoid "\"\"")
- I finally opted for a non-parameter %page-size (yes, I changed my mind
  :-), I just didn't see any reason to use one)
- I removed ('page (string->number param)) from REQUEST-PARAMETERS (I
  think it was useless)
- I added a missing copyright header

And that's all!

Thanks for this work, it'll be very useful.  Don't hesitate send new
patches to improve it!

Best regards,
Cl=C3=A9ment