* Re: 01/02: services: cups: Rename ‘retry-this-job’ to ‘retry-current-job’.
[not found] ` <20190831012511.10FCC2047A@vcs0.savannah.gnu.org>
@ 2019-08-31 19:10 ` Ludovic Courtès
2019-08-31 23:13 ` Tobias Geerinckx-Rice
0 siblings, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2019-08-31 19:10 UTC (permalink / raw)
To: guix-devel, Tobias Geerinckx-Rice
Hi there!
guix-commits@gnu.org skribis:
> commit 5a097cdd5446587511dbee049ad706366c74e5ad
> Author: Tobias Geerinckx-Rice <me@tobias.gr>
> Date: Sat Aug 31 03:23:16 2019 +0200
>
> services: cups: Rename ‘retry-this-job’ to ‘retry-current-job’.
>
> * gnu/services/cups.scm (error-policy, cups-configuration): Substitute
> RETRY-CURRENT-JOB for the obsolete RETRY-THIS-JOB name of this policy.
> * doc/guix.texi (Printing Services): Likewise.
[...]
> (define-enumerated-field-type error-policy
> - (abort-job retry-job retry-this-job stop-printer))
> + (abort-job retry-job retry-current-job stop-printer))
I’m not sure how ‘define-enumerated-field-type’ works, but can we add a
‘define-deprecated’ for ‘retry-this-job’ or similar?
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: 01/02: services: cups: Rename ‘retry-this-job’ to ‘retry-current-job’.
2019-08-31 19:10 ` 01/02: services: cups: Rename ‘retry-this-job’ to ‘retry-current-job’ Ludovic Courtès
@ 2019-08-31 23:13 ` Tobias Geerinckx-Rice
2019-08-31 23:27 ` Tobias Geerinckx-Rice
0 siblings, 1 reply; 4+ messages in thread
From: Tobias Geerinckx-Rice @ 2019-08-31 23:13 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: guix-devel
[-- Attachment #1: Type: text/plain, Size: 591 bytes --]
Ludo',
Ludovic Courtès 写道：
>> (define-enumerated-field-type error-policy
>> - (abort-job retry-job retry-this-job stop-printer))
>> + (abort-job retry-job retry-current-job stop-printer))
>
> I’m not sure how ‘define-enumerated-field-type’ works, but
> can we add a
> ‘define-deprecated’ for ‘retry-this-job’ or similar?
‘retry-this-job’ was never[0] valid, so I think failing loudly
is the right thing to do here. CUPS wouldn't have known what to
do with it anyway.
Kind regards,
T G-R
[0]: https://github.com/apple/cups/issues/5301
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: 01/02: services: cups: Rename ‘retry-this-job’ to ‘retry-current-job’.
2019-08-31 23:13 ` Tobias Geerinckx-Rice
@ 2019-08-31 23:27 ` Tobias Geerinckx-Rice
2019-09-03 12:51 ` Ludovic Courtès
0 siblings, 1 reply; 4+ messages in thread
From: Tobias Geerinckx-Rice @ 2019-08-31 23:27 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: guix-devel
[-- Attachment #1: Type: text/plain, Size: 422 bytes --]
Tobias Geerinckx-Rice 写道：
> ‘retry-this-job’ was never[0] valid, so I think failing loudly
> is
> the right thing to do here. CUPS wouldn't have known what to do
> with
> it anyway.
Sorry, sent too soon. So: this was never more than a broken typo
(albeit one that slipped in via CUPS itself), I don't think it
deserves too much attention. (Which I've now just given it :-)
G'night,
T G-R
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: 01/02: services: cups: Rename ‘retry-this-job’ to ‘retry-current-job’.
2019-08-31 23:27 ` Tobias Geerinckx-Rice
@ 2019-09-03 12:51 ` Ludovic Courtès
0 siblings, 0 replies; 4+ messages in thread
From: Ludovic Courtès @ 2019-09-03 12:51 UTC (permalink / raw)
To: Tobias Geerinckx-Rice; +Cc: guix-devel
Tobias Geerinckx-Rice <me@tobias.gr> skribis:
> Tobias Geerinckx-Rice 写道：
>> ‘retry-this-job’ was never[0] valid, so I think failing loudly is
>> the right thing to do here. CUPS wouldn't have known what to do
>> with
>> it anyway.
>
> Sorry, sent too soon. So: this was never more than a broken typo
> (albeit one that slipped in via CUPS itself), I don't think it
> deserves too much attention. (Which I've now just given it :-)
Heh, makes sense. :-)
Ludo’.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-09-03 12:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190831012509.23965.2195@vcs0.savannah.gnu.org>
[not found] ` <20190831012511.10FCC2047A@vcs0.savannah.gnu.org>
2019-08-31 19:10 ` 01/02: services: cups: Rename ‘retry-this-job’ to ‘retry-current-job’ Ludovic Courtès
2019-08-31 23:13 ` Tobias Geerinckx-Rice
2019-08-31 23:27 ` Tobias Geerinckx-Rice
2019-09-03 12:51 ` Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).