From: Mathieu Othacehe <m.othacehe@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: Cross-compilation broken on canonical packages.
Date: Fri, 06 Mar 2020 10:19:30 +0100 [thread overview]
Message-ID: <87r1y5et7h.fsf@gmail.com> (raw)
In-Reply-To: <87r1ykj776.fsf@gnu.org>
Hey Ludo,
> Do we need to do it for ‘lower-object’? I think that one is (almost)
> always called from a gexp compiler where it’s explicitly passed ‘system’
> and ‘target’.
Yes because of lower-object call in "system-derivation" procedure of
(gnu services).
> Also, a test or two would be welcome as it’s easy to break it without
> noticing.
>
> Otherwise LGTM, thank you, and sorry for the delay!
Pushed with a few tests on core-updates, thanks for reviewing!
Mathieu
prev parent reply other threads:[~2020-03-06 9:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-14 11:49 Cross-compilation broken on canonical packages Mathieu Othacehe
2019-12-14 11:52 ` Mathieu Othacehe
2019-12-19 16:48 ` Ludovic Courtès
2019-12-22 16:31 ` Mathieu Othacehe
2019-12-30 18:48 ` Ludovic Courtès
2019-12-31 9:55 ` Mathieu Othacehe
2020-01-02 18:07 ` Ludovic Courtès
2020-01-02 22:00 ` Mathieu Othacehe
2020-01-03 12:03 ` Mathieu Othacehe
2020-02-11 13:01 ` Mathieu Othacehe
2020-02-11 14:04 ` Ludovic Courtès
2020-02-12 10:20 ` Mathieu Othacehe
2020-02-24 16:11 ` Ludovic Courtès
2020-03-06 9:19 ` Mathieu Othacehe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1y5et7h.fsf@gmail.com \
--to=m.othacehe@gmail.com \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).