unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludovic.courtes@inria.fr>
To: Josh Marshall <Josh.Marshall@jax.org>
Cc: "guix-devel@gnu.org" <guix-devel@gnu.org>
Subject: Re: [EXTERNAL]Re: Modifying squashfs usage for `guix pack` for supporting singularity
Date: Fri, 13 Mar 2020 17:38:51 +0100	[thread overview]
Message-ID: <87r1xwnrac.fsf@inria.fr> (raw)
In-Reply-To: <BL0PR06MB4673CCAF3B104474AF3FD0E9E9FD0@BL0PR06MB4673.namprd06.prod.outlook.com> (Josh Marshall's message of "Thu, 12 Mar 2020 17:58:59 +0000")

Hi Josh,

Josh Marshall <Josh.Marshall@jax.org> skribis:

> While the images seem to work well in most cases, removing ways for bits to change seems to be in the spirit of guix, and so the "-all-time" and "-mkfs-time" options remove one source of change.  Additionally, without the "--no-recovery" an extra file is made which is not useful to the process, and for my manual testing seemed to cause write or permission issues which could cause failures.  Guix already handles the failure cases in mksquashfs which the recovery file is for and so the redundant work is not helpful, can cause problems, slows down the process, and requires more resources.

Oh, I hadn’t understood that there were reproducibility issues with
‘guix pack -f squashfs’, sorry about that!

Commits 24fb0dc0ab34ebb49509a3d5b4d84d8488670807 and
b829864d747b3b24ef37cafe36e889527b060d4d implement what you suggest.

I can confirm that now something like:

  guix pack -f squashfs sed --rounds=2

passes, which was not the case before.

Thanks!

> As for the information given by `guix pack --list-formats`, I'd change to something like the following:
>
> ```
>   tarball       Self-contained tarball, ready to run directly on any Linux machine
>   squashfs      Container suitable for Singularity 2.x and 3.x
>   OCI       OCI compliant tarball ready for 'docker load' and usable by Singularity 3.x
>   sif         Unsupported; container preferred by Singularity 3.x

We cannot change the format name, for compatibility reasons, but I’ll
double-check that what ‘-f docker’ produces is indeed OCI, and if so,
add it to the description.

> For more information, refer to https://guix.gnu.org/manual/en/html_node/Invoking-guix-pack.html

I don’t think we’re going to add references to the manual in --help and
similar: it’s always implicit that documentation is in the manual.
However, perhaps we could add terminal hyperlinks to make it more
discoverable.

Thanks,
Ludo’.

  reply	other threads:[~2020-03-13 16:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-04 21:00 Modifying squashfs usage for `guix pack` for supporting singularity Josh Marshall
2020-03-04 22:28 ` Josh Marshall
2020-03-12 13:51 ` Ludovic Courtès
2020-03-12 14:05   ` [EXTERNAL]Re: " Josh Marshall
2020-03-12 16:39     ` Ludovic Courtès
2020-03-12 17:58       ` Josh Marshall
2020-03-13 16:38         ` Ludovic Courtès [this message]
2020-03-13 16:48           ` Josh Marshall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r1xwnrac.fsf@inria.fr \
    --to=ludovic.courtes@inria.fr \
    --cc=Josh.Marshall@jax.org \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).