From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id cB2RO+2Ssl9+GwAA0tVLHw (envelope-from ) for ; Mon, 16 Nov 2020 14:55:41 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id yHB2N+2Ssl8DewAAB5/wlQ (envelope-from ) for ; Mon, 16 Nov 2020 14:55:41 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B36D494053D for ; Mon, 16 Nov 2020 14:55:41 +0000 (UTC) Received: from localhost ([::1]:33872 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kefuu-0004Aq-LH for larch@yhetil.org; Mon, 16 Nov 2020 09:55:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35882) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kefu9-0004A6-0N for guix-devel@gnu.org; Mon, 16 Nov 2020 09:54:54 -0500 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:43156) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kefu7-00075G-6w; Mon, 16 Nov 2020 09:54:52 -0500 Received: by mail-wr1-x42f.google.com with SMTP id s8so18974232wrw.10; Mon, 16 Nov 2020 06:54:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=5noTJzFJWykh3mFJYDXlIc6pGQEikugAlMHXN6Hhp3g=; b=j5zJchhbmrNoIfLamMRW/vPe/8mPH6pKE64+2CuHIG8w7jI80hUeUJm6tmcAwx+4zT w5sNrYAEntAqFtP2PtQHOLpIGxEJcmaE3h7LDIlAHHv6rROszVrwBPeQtLDAqma1YCM0 GlcWcxEpWApSDHsUNWAmG2XZfeHNPe6QD4zchX+MdkjDXhLn9dpjQv0tfa8t09hHUYnn 3DGZ6AHFoBvTEepjNi5oGVF8d1shNmzyrYSwA0GE4g9lW9skj+VKlRmgGDtLvrrbs0oZ O2SWsy4A5I2oA6djKoo5ZAgsEPLN57fwHb0YIkvKfSEbs9rbcN+2PoEc16PL3mXdhBlK x4zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=5noTJzFJWykh3mFJYDXlIc6pGQEikugAlMHXN6Hhp3g=; b=ZHwc00uN1TqDJcCc0xpmXslo7xX9B0Tc4eYQhtTTahHKZ4G4/XSVdQlA8oigD/qlRx shrb6ZgjoNmOE36SsgxF1PyGdKnP/XtOGHIGf7rIJOL1JEcmET4XksNVLf39XsHHSchB 9lm2vum2kE7nneEdPvKmAlS/zSQYj3yTmI9s9IN2TdH6ltLH0O8v6a1liyi9Idbn/AC6 etIkPiM8KY6/ieL1JrwwzS5EGkVsBAsUDFwZM1l2dfDOnpWo2Z7OQahp7TmjUVFo2lR8 HgwQcHIpIO3ADKkHyt0ayyvCgwkgmxwj+ZOrg6omfadHmUnIp7bh6TBz9gc8nC+MgkLh OOhA== X-Gm-Message-State: AOAM533KSfmj7zL0Vl886qO8w9e9LUW8WT08r7/h9eviVNULTRiWgisd 0GlGLBFw2HV/DgLEW7urocSBbgnXR7s= X-Google-Smtp-Source: ABdhPJzl6856T+e/csWfTahGQk75sWIFAiTT7jmhC6ZkMQeX5wnK3Y7adsYd+vyRg5BAwPOlrFi5rg== X-Received: by 2002:adf:f783:: with SMTP id q3mr19296833wrp.88.1605538487189; Mon, 16 Nov 2020 06:54:47 -0800 (PST) Received: from unfall (20.134.94.90.dynamic.jazztel.es. [90.94.134.20]) by smtp.gmail.com with ESMTPSA id q16sm23307714wrn.13.2020.11.16.06.54.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 06:54:46 -0800 (PST) From: =?utf-8?Q?Miguel_=C3=81ngel_Arruga_Vivas?= To: Maxim Cournoyer Subject: Re: [PATCH] Automatically set `geiser-guile-load-path' from .dir-locals References: <87tuuixjno.fsf@gmail.com> <87zh3w5ytp.fsf@dustycloud.org> <87wnz05u7d.fsf@dustycloud.org> <87tuu46tqm.fsf@gmail.com> <87lff3iueo.fsf@dustycloud.org> <87y2j2c4u1.fsf@gmail.com> Date: Mon, 16 Nov 2020 15:54:43 +0100 In-Reply-To: <87y2j2c4u1.fsf@gmail.com> (Maxim Cournoyer's message of "Sun, 15 Nov 2020 23:18:14 -0500") Message-ID: <87r1otxsgc.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=rosen644835@gmail.com; helo=mail-wr1-x42f.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=gmail.com header.s=20161025 header.b=j5zJchhb; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: hyYyQAaVaDWm --=-=-= Content-Type: text/plain Hi Maxim and Christopher, Maxim Cournoyer writes: >[...] > Christopher Lemmer Webber writes: > [...] >> I figured out what was happening! The bug is *technically* in vc-mode. >> However, nontheless it manifested here... >> >> Here's what happened. vc-mode has some various hacks, as you can see >> above with "hack-local-variables-apply"... which traverses the dirlocals >> stuff. (Not sure what the purpose is, didn't look too long.) The file where these functions are located is lisp/files.el, right on the Emacs core. Some modes add hooks there, like flyspell or cc, but not vc, so I don't really think the problem is exclusive from that mode after some debugging. This code ends up in file-local-variables-alist, even though dir-local-variables-alist contains the correct values for some reason I still don't really understand. >> However for whatever reason, vc-mode also seems to be reusing buffers >> such as `*vc-diff*'... and somehow still is left in the directory >> context it *first* was used in. This may be the culprit but I think it isn't the issue, as file-local-variables-alist accumulates every eval marked as nil, not only the first/last one... when it fails, as we've seen. >> Thus if I C-x v = in a guix-oriented buffer first, and then switch to >> another completely different project and do the same, it's loading the >> dirlocals from Guix(...!!!!) >> >> This is clearly a bug in vc-mode, I'll try to report it as such. > Thank you for the investigation. I'd be really happy if you could > report the problem upstream (M-x report-emacs-bug) aznd link to it here! I haven't reported it yet, but as you can see I have a reproducer script attached. I haven't seen anything in vc-code that points in that direction, surely though Emacs people will have a better understanding. Christopher, would you mind to CC me if you open the bug? I can do it too if you tell me to, but I don't want to create a duplicate entry if we do it roughly at the same time. > [..] Miguel had written in IRC at the time of the initial report, but > to no avail. Maxim, could you test the script to check if we can narrow the cases? It shows the README in the emacs it opens, so it should be straight-forward. >> In the meanwhile, I used this hacky "fix". Maybe worth applying for the >> moment... what do you think of it? > > I'd like to have the upstream bug linked in that fix rather than the > Guix one; that way it'll be possible to track upstream resolution and > know when the workaround can be removed. Apart from the tracking reference, I agree that it's worth applying it. And also, thank you both for making easier to work on guix. :-) Happy hacking! Miguel --=-=-= Content-Type: application/x-sh Content-Disposition: attachment; filename=reproducer.sh Content-Transfer-Encoding: base64 Content-Description: reproducer IyEvYmluL3NoIC1leAoKYWRkX2hpc3RvcnkgKCkgewogICAgZWNobyAnRmlyc3QgbGluZScgPiBm aWxlCiAgICBnaXQgYWRkIGZpbGUKICAgIGdpdCBjb21taXQgLW0gJ2ZpcnN0IGNvbW1pdCcKICAg IGVjaG8gJ1NlY29uZCBsaW5lJyA+PiBmaWxlCiAgICBnaXQgYWRkIGZpbGUKICAgIGdpdCBjb21t aXQgLW0gJ3NlY29uZCBjb21taXQnCn0KCnRlbXBkaXI9IiQobWt0ZW1wIC1kKSIKdHJhcCAiY2Qg JiYgcm0gLXJmICcke3RlbXBkaXJ9JyIgRVhJVApjZCAiJHt0ZW1wZGlyfSIKZ2l0IGluaXQgcDEK Y2QgcDEKZWNobyAnKChuaWwgLiAoKGV2YWwgLiAobWVzc2FnZSAiRXZhbCBjYWxsZWQiKSkpKSkn ID4gLmRpci1sb2NhbHMuZWwKZ2l0IGFkZCAuZGlyLWxvY2Fscy5lbAphZGRfaGlzdG9yeQpnaXQg aW5pdCAuLi9wMgpjZCAuLi9wMgphZGRfaGlzdG9yeQpjZCAuLgoKZWNobyAnQy14IEMtZiBwMS9m aWxlIC0+IHByZXNzICEKQy14IHYgbApDLWggdiBmaWxlLWxvY2FsLXZhcmlhYmxlcy1hbGlzdCAo Y29udGFpbnMgZXZhbCBtZXNzYWdlPykKQy14IG8KQy14IEMtZiAuLi9wMi9maWxlCkMteCB2IGwK Qy1oIHYgZmlsZS1sb2NhbC12YXJpYWJsZXMtYWxpc3QgKHN0aWxsIGNvbnRhaW5zIGV2YWwgbWVz c2FnZT8pJyA+IFJFQURNRQoKZW1hY3MgLS1mZy1kYWVtb249ZGlybG9jYWxzIC1RICYKcGlkPSQh CgojIEdpdmUgc29tZSB0aW1lIHRvIHRoZSBkYWVtb24gdG8gc3RhcnQuCnNsZWVwIDUKZW1hY3Nj bGllbnQgLWEgJ2ZhbHNlJyAtcyBkaXJsb2NhbHMgLWMgUkVBRE1FIC0tbm8td2FpdAp3YWl0ICRw aWQK --=-=-=--