From: Mark H Weaver <mhw@netris.org>
To: Chris Marusich <cmmarusich@gmail.com>
Cc: guix-devel@gnu.org, John Doe <dftxbs3e@free.fr>, 45252@debbugs.gnu.org
Subject: Re: [PATCH] gnu: libffi: Add unreleased patch to fix float128 on powerpc64le.
Date: Wed, 23 Dec 2020 16:22:21 -0500 [thread overview]
Message-ID: <87r1ngi5ef.fsf@netris.org> (raw)
In-Reply-To: <87r1nhdo2i.fsf@gmail.com>
Hi Chris,
Chris Marusich <cmmarusich@gmail.com> writes:
> Mark H Weaver <mhw@netris.org> writes:
>
>> Earlier, I wrote:
>>> When invoking 'patch' in Guix, you should *always* use "--force" instead
>>> of "--batch".
>>
>> (See <https://bugs.gnu.org/45252#19> for my earlier message).
>
> Thank you for letting me know about this. I didn't know about the
> difference between "--batch" and "--force". I agree we should use
> "--force" instead of "--batch". How do you recommend that I proceed?
Simply changing "--batch" to "--force" on line 79 (in the powerpc64le-*
case, i.e. the one that was just added) seems like the right thing.
That will force a rebuild of almost everything on the powerpc64le-*
architecture, but should not cause any rebuilds on other architectures.
>> Since writing the message above, I've found another problem in the same
>> commit (7eaa2f24ea77cddbb4bbc2d6a6905673a36f8f99): it searches for the
>> 'patch' program in 'inputs'. This is a mistake, because when
>> cross-compiling, 'inputs' will contain software compiled to run on the
>> target system instead of the build system.
>
> Is it searching for the "patch" program, or is it searching for the
> patch file? It looks to me like the code is searching for the patch
> file in inputs, not the "patch" program.
LOL, you're right, I got confused. Please disregard my second email in
this thread, and apologies for that noise.
> Again, thank you for taking the time to bring these topics up. I'm
> always trying to make sure I do things the best way I can in Guix, so I
> appreciate the feedback.
Thank you, Chris.
Warm regards,
Mark
prev parent reply other threads:[~2020-12-23 21:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 5:15 [PATCH] gnu: libffi: Add unreleased patch to fix float128 on powerpc64le Mark H Weaver
2020-12-22 6:00 ` Mark H Weaver
2020-12-23 6:38 ` [bug#45252] " Chris Marusich
2020-12-23 7:50 ` Efraim Flashner
2020-12-23 21:34 ` Mark H Weaver
2020-12-28 4:17 ` [bug#45252] [PATCH] gnu: libffi: Add unreleased patch to fix float128 on powerpc64le., [bug#45252] [PATCH] gnu: libffi: Add unreleased patch to fix float128 on powerpc64le., [bug#45252] " Chris Marusich
2020-12-23 21:22 ` Mark H Weaver [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1ngi5ef.fsf@netris.org \
--to=mhw@netris.org \
--cc=45252@debbugs.gnu.org \
--cc=cmmarusich@gmail.com \
--cc=dftxbs3e@free.fr \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).