From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id cKK6LYOONmDAEQAA0tVLHw (envelope-from ) for ; Wed, 24 Feb 2021 17:36:03 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id IP+iKYOONmAMbAAAB5/wlQ (envelope-from ) for ; Wed, 24 Feb 2021 17:36:03 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 500A59C63 for ; Wed, 24 Feb 2021 18:36:03 +0100 (CET) Received: from localhost ([::1]:41056 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lEy4w-0002Dm-Fa for larch@yhetil.org; Wed, 24 Feb 2021 12:36:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53096) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEy3W-0001X1-8I for guix-devel@gnu.org; Wed, 24 Feb 2021 12:34:34 -0500 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]:39140) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lEy3U-0002Gu-D7; Wed, 24 Feb 2021 12:34:33 -0500 Received: by mail-pj1-x1032.google.com with SMTP id d2so1801291pjs.4; Wed, 24 Feb 2021 09:34:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=bcxVQ0ey2dmIOmqoHzwYsXBU9npmjYi1vW0FE2NR5B8=; b=G5kFT6pGvXaTqnYCtVuneQnCxJzWI+d8uGF4Rjb9xIMvoOuJWAE8ZVV7ct1MWb9D1R MZNvwgdfkzLB0PJ0K9npVYvMHn4NWF40Wf8NIyMonK3T5fZLJkYrxfpFkIyUlFTmA9ei 2JKxAaebzLvFmB/IbaWe8piKTyr9p5gG2Lu8by3y1zcF3qN+hNvtvjm+rccttkc2Zj6J 71T1EUTtVTvBcFr1epI82c8Nbype8dXNzH3UQrgi6lAeNJOVrnvbGSENQzSsR2b+rbw1 GjENfHsSB3hsPPKgj6S0zJgT+AymdAbjmvPdiRHIaDHsjbI0wBXkZdF0fNrlaJtqQcZq x6mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=bcxVQ0ey2dmIOmqoHzwYsXBU9npmjYi1vW0FE2NR5B8=; b=hWQbEjNs/AgJEvoUubAondYMRbKT58dJNFJZvqGRTK19VhOKXoYVRhmywImStAu3LY r0c8lPu0vVn5Os6ZzqTsJwzcVzOoHXJCnAzjNjtw184gtFnDBmz8E6yQUE1PRBVGYLTA MWkBKNaUE0Sfradjc9CT+2yi2p299O6vwQNd5LXhyT8wWtcZ8hDtwVjUjK4lC4iMEkow TN/7b550rUDna8TSCf1scSmM/G7zcz4fm94vgwo/olRKpR96x05px4doceN1RoM9eS9N oKx7RsBy7v9KQUz+UzBk5gq5VvWPevs/WnFGG7ejLR6yGU4IpEttHVjN5YgwsGT30my6 tRoQ== X-Gm-Message-State: AOAM530xJv6b5Gh5EZr0YultfnQdqX9B4FaSQXuNvub4h1U+wEPzgcvA F59eDd0602/oTdk7LuakxHn/0csgO/67Qg== X-Google-Smtp-Source: ABdhPJyFlNpiX651DK8Xw23INaPw+u3ysF49cLy1qG5c/JWZQEnrJrR4Lf0xxFj7Rpxmp/G36Ghazw== X-Received: by 2002:a17:902:c941:b029:e3:8c4e:8499 with SMTP id i1-20020a170902c941b02900e38c4e8499mr33957867pla.58.1614188069779; Wed, 24 Feb 2021 09:34:29 -0800 (PST) Received: from garuda-lan (c-24-18-44-142.hsd1.wa.comcast.net. [24.18.44.142]) by smtp.gmail.com with ESMTPSA id h6sm3094667pfv.84.2021.02.24.09.34.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Feb 2021 09:34:28 -0800 (PST) From: Chris Marusich To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: 02/03: tests: gremlin: Skip file-needed/recursive if DT_NEEDED is empty. References: <20210224094215.22478.70281@vcs0.savannah.gnu.org> <20210224094221.846A320536@vcs0.savannah.gnu.org> <87y2fd3gy5.fsf@gnu.org> Date: Wed, 24 Feb 2021 09:34:25 -0800 In-Reply-To: <87y2fd3gy5.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Wed, 24 Feb 2021 11:20:34 +0100") Message-ID: <87r1l55pzy.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Received-SPF: pass client-ip=2607:f8b0:4864:20::1032; envelope-from=cmmarusich@gmail.com; helo=mail-pj1-x1032.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -5.17 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=G5kFT6pG; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 500A59C63 X-Spam-Score: -5.17 X-Migadu-Scanner: scn0.migadu.com X-TUID: NIoQnsaXyVR6 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ludo, Ludovic Court=C3=A8s writes: > guix-commits@gnu.org skribis: > >> +++ b/tests/gremlin.scm >> @@ -61,7 +61,12 @@ >> (elf-dynamic-info-needed dyninfo)))))) >>=20=20 >> (unless (and %guile-executable (not (getenv "LD_LIBRARY_PATH")) >> - (file-needed %guile-executable)) ;statically linked? >> + (file-needed %guile-executable) ;statically linked? >> + ;; When Guix has been built on a foreign distro, using a >> + ;; toolchain and libraries from that foreign distro, it is= not >> + ;; unusual for the runpath to be empty. >> + (and=3D> (file-runpath %guile-executable) >> + (compose not null-list?))) > > Nitpick: you can write =E2=80=98pair?=E2=80=99 instead of =E2=80=98(compo= se =E2=80=A6)=E2=80=99. Thank you for the suggestion! I've done this in commit b22dcb24207022d9a716893836578e96f4b580a1. > I guess the problem is that =E2=80=98file-needed/recursive=E2=80=99 only = looks at > RUNPATH, ignoring the notion of =E2=80=9Cstandard directories=E2=80=9D li= ke /usr/lib. Yes, that's exactly my thought as well. Is it intended that "gremlin.scm" should be able to search those places? My understanding is that the answer is no, we don't expect it to be able to search those places, since in theory (despite the Filesystem Hierarchy Standard) the directories to search could be anywhere, depending on how libraries are managed by the foreign distro, and this code is intended primarily to be used on the build side, where we wouldn't encounter such cases anyway. My understanding is that skipping this test is the right solution, rather than attempting to teach gremlin to always be able to find libraries when the runpath is empty. What do you think? =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAmA2jiEACgkQ3UCaFdgi Rp091w//Urg1mRY0IcafbLRyShFJgzXORQcOhquUmPn6wOGAvTnvkRdoABleVQ4x jgkyQfH5LFN3344LeQc9JPMZEGW20/wbf9gSpCwYU4dBsvaMPekP0AMmPDh6axn4 dp2rI8ILd3wmzLZFD9Q+nPmuH9WoXQEIWL28Bt828nRMmPVOoOwRBDd/KTpL4a4/ M7ZWGISuvFljfo0MxcTAg5AjBdKwDZbBie3DrhLGZRnxppkQlZPg8XPb8S0fsN2y nxDyb4DEq46EnVTp1jpMuoi0DdYPvsVZBthW7/BqtbA0Yy9z8C6u1YntS+BKt1TZ yrKfDIFasKKF22GkuKg0LCVpgAwuFvtH2hNYqKut3y2MGyFpXCL2DDFMOeW6nuS9 s1j7GRapxIKlZSvwMA+JbTHnXRCpb2GpkPf5O0nSiafiNJlt3sVi+oPKptviq+Vd N60TodIQ6mkA+2xWh1UxeiluKesPiq0sR4UyhP+Vq2RYHgsL7JKcYFrweScfHwqI jTn3tkz9cuMF1Ji1KJE36CpelK7obaG81f0L2kcRDHWOVlQj/ihXfw2QvZXhdz8U 6H2bFEf2Kfjkk6mYojKLrPryVV/fv8XZtzT2pgUOJrt/OB5lTjTGl9i6IvsVO+b8 BwvxBNuGiZFLKfGcx0mGO/t8VYLyyMMKpl2RT9TN8P1WUifxaj4= =Qg0d -----END PGP SIGNATURE----- --=-=-=--