unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: zimoun <zimon.toutoune@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] display grafted package
Date: Tue, 30 Mar 2021 14:15:59 +0200	[thread overview]
Message-ID: <87r1jwg7ls.fsf@gnu.org> (raw)
In-Reply-To: <86im5a6ea4.fsf@gmail.com> (zimoun's message of "Mon, 29 Mar 2021 01:37:23 +0200")

Hi,

zimoun <zimon.toutoune@gmail.com> skribis:

> The attached patch does that only for ’package->recutils’ (show and
> search).  For instance, note the ’replaced’ field for the grafted
> package.  (Obviously, it could be any other word than ’replaced’
> compatible with the recutils record.)

[...]

> name: zstd
> version: 1.4.4
> replaced: 1.4.9

I’d make it “replacement” rather than “replaced”.

> How display such information for ’package -A’?  The (selected) output
> looks like:
>
> zstd	1.4.9	out,lib,static	gnu/packages/compression.scm:1473:2
> zstd	1.4.4	out,lib,static	gnu/packages/compression.scm:1402:2

Ultimately, you’d want ‘fold-packages’ to traverse replacements, but I
don’t think that’s a good idea because it would break the assumption
that ‘fold-packages’ only traverses public packages.

All in all, I’m in favor of either the status quo or the
‘package->recutils’ patch you propose.

Thanks,
Ludo’.


      reply	other threads:[~2021-03-30 12:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-28 23:37 [PATCH] display grafted package zimoun
2021-03-30 12:15 ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r1jwg7ls.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).