From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id YBQVOqK1gWA6ZAAAgWs5BA (envelope-from ) for ; Thu, 22 Apr 2021 19:42:58 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 0OLQNaK1gWA4BwAAB5/wlQ (envelope-from ) for ; Thu, 22 Apr 2021 17:42:58 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8271316F47 for ; Thu, 22 Apr 2021 19:42:58 +0200 (CEST) Received: from localhost ([::1]:34994 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZdLt-0008W2-Ak for larch@yhetil.org; Thu, 22 Apr 2021 13:42:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53550) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZdLg-0008Vt-24 for guix-devel@gnu.org; Thu, 22 Apr 2021 13:42:44 -0400 Received: from world.peace.net ([64.112.178.59]:37968) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZdLd-0007rs-A2 for guix-devel@gnu.org; Thu, 22 Apr 2021 13:42:43 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lZdLW-0001Jh-MR; Thu, 22 Apr 2021 13:42:34 -0400 From: Mark H Weaver To: Raghav Gururajan , Guix Devel Subject: Another misleading commit log (was Re: A "cosmetic changes" commit that removes security fixes) In-Reply-To: <87y2daz13x.fsf@netris.org> References: <87tunz11mf.fsf@netris.org> <87y2daz13x.fsf@netris.org> Date: Thu, 22 Apr 2021 13:40:47 -0400 Message-ID: <87r1j2z079.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=64.112.178.59; envelope-from=mhw@netris.org; helo=world.peace.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Prikler Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619113378; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=3XKEaDd/mXWAzYDXWzBnzwMb1/X7FEbospmQ1ODSOos=; b=KjpJzNRF0XMyuTUYDbe70FVRq3a2VegjUiBJDiULdSWwdtOfHaK5Gzz0JUFY/09k8B5cD5 5P+KoeziJLuIY6Qrx0E23XjC0Rr3Fzma/uwmOKSBEFNJUQFMgJ0hjwLVVH/WZ/ZLHuTgsD HJgLNpjuazOrrRIIF5gaPHCORud3x8klYBwb/kzIpfiLUuJhV1hpeOcN+7CN9gV3TwG2hx cYqmeiHuk7BQUx4XjzifjgUQcAuiqi8mcW28nr/cRfBy5ypcm99Cdu//Q9Bffnq/9XyXc6 os/zbzCx/VtiZ1E6cpefvjWuP8O3+0FXY0DGrrKPoe2hPrGlf71HUPEub+vvvg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619113378; a=rsa-sha256; cv=none; b=fG4gTQqbdb9G1dLHh8jJLakttes/Iquti3n6NAOvvlHmqDAEb7LYyRVtrVxR6ClGMV/2UE 2QY6oUjkYH2QdmMXJ+tCm5IXoXl0cBVAyDCw6O2qPQr4Om1dnUmmOV3FRyqBcIbirkDV3H J4DhU1DcQuabRMGOezhg7Rslx+hTj/fGK2u/hb3uwDQsny4RzO80yQ3xsTf1k7M4aJDNpc 2oJzzYqmtj2WW8CS01B6kiRa7ukQAbsgXVOdFoO76FswBt40MmoFfnnzBadQkfN0nJ9Y9u yrfADmiAZin3yBO0zoRbGYgIoXWSZoLaG4jVvkz+k0kgWJz/XpmgBHqpU0wIdQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -2.44 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 8271316F47 X-Spam-Score: -2.44 X-Migadu-Scanner: scn0.migadu.com X-TUID: KKc2kDIeTVpL Here's another commit with a blatantly misleading commit log: https://git.savannah.gnu.org/cgit/guix.git/commit/?h=3Dwip-gnome&id=3Df5f= c3c609e2f38ca1c0523deadb9f77d838fbf32 The summary line is "gnu: gdk-pixbuf: Add missing arguments", but in fact it does all of the following: (1) Ungrafts 'gdk-pixbuf'. (2) Updates 'gdk-pixbuf' from 2.40.0 to 2.42.2. (3) Removes the 'disable-failing-tests' phase. (4) Adds "#:meson ,meson-0.55" and "#:glib-or-gtk? #t" to the arguments. Most of the changes above are not mentioned in the commit log at all, and of course the summary line is extremely misleading. This commit was digitally signed and pushed to the 'wip-gnome' branch by Raghav, but it's also "Signed-off-by: L=C3=A9o Le Bouter", so I'm not sure who bears primary responsibility for this one. Mark --=20 Support Richard Stallman against the vicious misinformation campaign against him and the FSF. See for more.