From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 8NSkMRCAoGIr9gAAbAwnHQ (envelope-from ) for ; Wed, 08 Jun 2022 12:55:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id yBGbMBCAoGIAHQAAG6o9tA (envelope-from ) for ; Wed, 08 Jun 2022 12:55:12 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 835AA312A6 for ; Wed, 8 Jun 2022 12:55:12 +0200 (CEST) Received: from localhost ([::1]:48526 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nytLC-00086g-HT for larch@yhetil.org; Wed, 08 Jun 2022 06:55:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36276) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nytKk-00086W-Lg for guix-devel@gnu.org; Wed, 08 Jun 2022 06:54:42 -0400 Received: from ns13.heimat.it ([46.4.214.66]:47268) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nytKi-0003OA-VK; Wed, 08 Jun 2022 06:54:42 -0400 Received: from localhost (ip6-localhost [127.0.0.1]) by ns13.heimat.it (Postfix) with ESMTP id 90B8530087D; Wed, 8 Jun 2022 10:54:37 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at ns13.heimat.it Received: from ns13.heimat.it ([127.0.0.1]) by localhost (ns13.heimat.it [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Y8qIBdngLgCR; Wed, 8 Jun 2022 10:54:35 +0000 (UTC) Received: from bourrache.mug.xelera.it (unknown [93.56.171.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by ns13.heimat.it (Postfix) with ESMTPSA id C053330085C; Wed, 8 Jun 2022 10:54:35 +0000 (UTC) Received: from roquette.mug.biscuolo.net (roquette [10.38.2.14]) by bourrache.mug.xelera.it (Postfix) with SMTP id 531A91B69F86; Wed, 8 Jun 2022 12:54:35 +0200 (CEST) Received: (nullmailer pid 8711 invoked by uid 1000); Wed, 08 Jun 2022 10:54:34 -0000 From: Giovanni Biscuolo To: Ludovic =?utf-8?Q?Court=C3=A8s?= , Arun Isaac Cc: Guix Devel , GNU Guix maintainers Subject: Re: On commit access, patch review, and remaining healthy In-Reply-To: <87fskha2nr.fsf@gnu.org> Organization: Xelera.eu References: <87ee07m77w.fsf@gnu.org> <877d5um1oe.fsf@systemreboot.net> <87fskha2nr.fsf@gnu.org> Date: Wed, 08 Jun 2022 12:54:34 +0200 Message-ID: <87r13zifx1.fsf@xelera.eu> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=46.4.214.66; envelope-from=g@xelera.eu; helo=ns13.heimat.it X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1654685712; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=qZu/uiv+A/DRearbdBsUVE2LASQAUp/itRWyPrPhNkI=; b=ZVhxP/3AK2mWlJwGeZB/nXwD0QrMKD2Jkt1bLeQTVgP46QEk/YQ6GmTeZOm6RNxEZ8jBd6 3MEOLXMwzq/yIVmRuSogMVSFFexwBRUQzeBmj5Tcn3vM3a5zsB+ytQ0/lkofRjohcXYoAK JxS3VcGBi8jICZQCdnCKPjEUieqRtuYLUU65wgQLtH7tT8z7xI0/KifxcY2/d9d9JoSJYg SiGGU60pJKq4n31TjWWc5UyMNKieLwteIiT9ckylkYLIySZ1l/Q8fX/b3nJYcWfqQBo5GT XZg3O1toCm+saiS4Ph4JUVpqCv/2m7s79nXGWDAkwUflwz8KkG1TCDC1PGqG+w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1654685712; a=rsa-sha256; cv=none; b=K80zXkphKdryjx0oO/mOtG8QOwNcg48RvBK5mhmaqvN2YtWwx3RzkMOAJ6j+v9IMaO7dYZ +S37RkkMgd3vN99F9hRI1dkVzteGJEoSxLaTymJZCDJCgz5gJBDtV32WFTss+dqjwDCigr BnxwaVjwpdfpEq4KLNI4jI+GHWruQNqOdYblXEXuSH3++p7BUIHqgiTFdC20gZLfpW1NVZ MZh6hvIll4LPT5IER+qlQx5Cdvg2VKDhcvqWcMQ8MKAaQJ/5JWoTjMdVauVbd7jgrh4U6L hzdeX3OA6Sy/0h6Yf+WG6DGOfqgYpCwaOiPqPRxfE/ff6DPXmeCOWZjBAYzdZA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.20 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 835AA312A6 X-Spam-Score: -4.20 X-Migadu-Scanner: scn0.migadu.com X-TUID: IIg+1sKYoPcU --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ludo' Ludovic Court=C3=A8s writes: [...] > OK, understood. > > I can think of two ways to reassure committers: > > 1. By having clear reviewer check lists (you=E2=80=99d do that if you t= ick all > the boxes, you=E2=80=99re fine); also a description of the review process used by you and other experienced patch reviewers could be much useful: it's more /how/ do you check al the aspects of a patch (it's not only running "guix lint" obviously) than /what/ do you check, IMHO maybe this could be a specific chapter of the cookbook, maybe some experienced patch reviewer could make a sort of (reharshed) "live patch review" video of some patch representing interesting "class of patches" reviewers may encounter (upstream updates, changes in Guix package structure, patches to fix building issues...) if available I'd also attend a paid "Contributing Guix" course, since it would be /very/ useful to my work... but that's out of scope here, I think > 2. By improving automation=E2=80=94nothing new here: if there was a tic= k that > says =E2=80=9Capplies without merge conflicts=E2=80=9D and another o= ne that read > =E2=80=9Cbuilds fine=E2=80=9D, anyone could lightheartedly hit the = =E2=80=9Cmerge=E2=80=9D > button. OK but this can also be achieved now without automation, just by commenting the patch submission so that committers can "reuse" the work already done by others; a check-list can help for sure: could it be auto-generated by debbugs via a mail-template on receiving a message in the patch-list? > #2 is going to take time I=E2=80=99m afraid, but at least #1 is actionable > (=E2=80=98guix lint=E2=80=99 should help, too). > > WDYT? Are there other possibilities that come to mind? is it possible to automate "guix lint" (and add it as git hook before commit?) only for the package(s) specific to a patch-set? [1] [...] > And yes, we should take advantage of the WhereIsEveryone meetups and > guix-mentors to get to know each other, to help each other, and to > demystify the whole thing. I'd not miss the chance to someway document important things said during meetings/IRC/email-messages useful to demystify the whole thing: I know it's more work for some of you, but hopefully for less work in the future [...] Thanks! Gio' [1] that is: is there a command that given a patch is able to give us a list of affected guix packages? =2D-=20 Giovanni Biscuolo Xelera IT Infrastructures --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJABAEBCgAqFiEERcxjuFJYydVfNLI5030Op87MORIFAmKgf+oMHGdAeGVsZXJh LmV1AAoJENN9DqfOzDkSF+YP/0dlIfTgfNf3F/crVaLcT15/1mPeV4h8AkxC10gn lzsZJPGTeXLbJPf4we5lWGK46wqC4RU63lk1D35wBcr6X6W10sFq8VP6o0yOKRAb kyVbZ13x+T6ZfknY/jkfNQqTVG6iR24ZkhYxPIv/3no+VWAwd0vU1cNJz9yUUGaz Zeyi4JotkwvMqHnhclW3Y0awG/wlN19/sW7uErsQKjGGBRh6pM2HMVgkjTTIbAy9 R21AKSkOkLB3FdHk/+nJ+3mKGqw3NqEtXmjrj6P1TPMjwKWRJadJjYL5SjpvdXcY Q8qkCSCUc0OEiWWhlzaG8QGWx/HtpCXhC3dtkstGj1U2bBWKXUXGD1YdjX9x3nQ+ B/UVD7AukKFLTmc8F3zf42tkaY/JzmKv8EBOBIuwBJW4mTZo4dxp28N5GmFjKvsQ nfpe9iY3ytTYgIBZNjDSjF/oS+6DNi6YbMebNIGApy9UU87pBeIIUkZQy7xOE0Ua CYALgJuDPWGPH7F1Ah67FpjTrU0vWAeXTHRJhmwZnCCrPbYYrxEVQrcDufKiInfx LRCzMwb6iP/Uu9wn/ECPFDQVgXLoILoRqn3W24SnDD9Ud2t0FxGhKIF3Czc5WLb1 abpB9aMv7qbSsR0IhAILPiLIyzfY/NaafNkEJpg3Qst+rGdxT7/nRC2P6sqW4eKa letp =mnGk -----END PGP SIGNATURE----- --=-=-=--