From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id YFe7GbnV/2MD6wAAbAwnHQ (envelope-from ) for ; Wed, 01 Mar 2023 23:46:17 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id wBfJGLnV/2MJGwEAG6o9tA (envelope-from ) for ; Wed, 01 Mar 2023 23:46:17 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BFB0DA215 for ; Wed, 1 Mar 2023 23:46:16 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pXVD5-0002hf-17; Wed, 01 Mar 2023 17:46:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXVD1-0002gh-0T for guix-patches@gnu.org; Wed, 01 Mar 2023 17:46:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pXVD0-00087S-OT for guix-patches@gnu.org; Wed, 01 Mar 2023 17:46:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pXVD0-0003Ep-2h for guix-patches@gnu.org; Wed, 01 Mar 2023 17:46:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#61894] [PATCH RFC] Team approval for patches Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 01 Mar 2023 22:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61894 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: guix-devel@gnu.org, 61894@debbugs.gnu.org, guix-maintainers@gnu.org Received: via spool by 61894-submit@debbugs.gnu.org id=B61894.167771074412416 (code B ref 61894); Wed, 01 Mar 2023 22:46:02 +0000 Received: (at 61894) by debbugs.gnu.org; 1 Mar 2023 22:45:44 +0000 Received: from localhost ([127.0.0.1]:55218 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXVCi-0003EC-6z for submit@debbugs.gnu.org; Wed, 01 Mar 2023 17:45:44 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51724) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXVCf-0003Dr-Kv for 61894@debbugs.gnu.org; Wed, 01 Mar 2023 17:45:42 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXVCX-00083n-6D; Wed, 01 Mar 2023 17:45:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=BaepkHl5Pm+YpgJ5IOukomqJp/eZUFLMQYkAbbsa4+U=; b=FJQZYCtm8w2Lnl8Hb3eC KvN9Bu8hVprw4x8iza9mGwhSY5oT3ZEYoXilROn5HMPzbs+mlPLoBvVmTn/CR+s/LugLGYEQYSxR5 p/mqoyld/I5IoLIOZF2urqmtQtJBQxl/XkmXLYfN57AO7pJyHGwhzqQmD1CRFSaCBeiboPBUgua66 AKkgNeGcccLwTGdDD0aDes8b+ESfulyXYcxwZECjjgNvbnr3PtQpNOytdZUmmgWjiDb8WmqlKIuT8 DN0+krMg33mO7ZYGZveoNfF2xRdCwIyIJv45SAvmH6RRk9kQ2jLVwx2RulDSYIT/eAq1WstWY2BIW WSrndT+AWHbovw==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXVCU-0000cb-1D; Wed, 01 Mar 2023 17:45:31 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <878rgga1qv.fsf@inria.fr> <871qm8wf8e.fsf@cbaines.net> Date: Wed, 01 Mar 2023 23:45:27 +0100 In-Reply-To: <871qm8wf8e.fsf@cbaines.net> (Christopher Baines's message of "Wed, 01 Mar 2023 17:15:26 +0000") Message-ID: <87r0u86qgo.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1677710777; a=rsa-sha256; cv=none; b=pLHBe0U0Eb8CPdnnUTruMqJVvGb9zpt/eFWEqIKHdqvUvimts7T0OYgkPHQda/pd2/ODdW yC6OBhpcKJEVmKp2vvtaQpkdnTBS/GhkSXhW6g9kBkYQgFMdmNZQbeAp9vgdPFAA+JW9Ec J/ULvlFG7KQuoN/5hUFWFErNkCRpnTjiQmQ5pOOuAVSuKSRQdPMLE9P67Z96XXCGlUXTvq cNKVCPYwq3c/qagx2jDRLBwoLMjSgsm+0Q/7nqMZ4dnoTIbOVnVx1VLZ+us633ej/6y4Uz 3akeZi0wuKtdOZRHmsyIsU5TwgcGSp/wpo+WgbXI02oMI7zXdFFLPt1f7XqWxA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=FJQZYCtm; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1677710777; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=BaepkHl5Pm+YpgJ5IOukomqJp/eZUFLMQYkAbbsa4+U=; b=Y364BWZBSOte6P8ZO8EmZ0WWIaZi7uaMAazKCzxXF6RuRcoTz+Ad0T/gRC5O4j2lbSOint rKzs9X6CC0HzeXJ9GWeaSJ5So6quzupgSjXR1/GS5Qo/QHh3eUz0jQu4tSBy6bNwJbvxG2 JHkXudic5zaj1R/cNudHhookbT+bOmVj+Py/aW3c8XtCvliFWr7Ss2fE9ytZ/5jC3k2133 CDgH4xuXP+hvAKW5WOhh/4mYz8PtoUn6vgtIcyPDf5bAaH+SijCceoEWEKVXbQb76ZFhSn ShVdBXa52UkqvuTr5llkHrtZ7boi7SSe6uTYtjEJxfvNY9pzvVtQRN9yA465pg== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -2.59 X-Spam-Score: -2.59 X-Migadu-Queue-Id: BFB0DA215 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=FJQZYCtm; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-TUID: TGJUf65xDxDh Hi Chris, Christopher Baines skribis: > I guess I'm still a team sceptic, I think the idea is interesting and I > have added myself as a member of some teams. But the main impact on me > so far is that I've just been getting some unwanted personal email, > messages that previously wouldn't have landed in my inbox have been > doing so. Same for me (took me a while to understand why I was suddenly Cc=E2=80=99d = on some many patches. :-)) I=E2=80=99m not sure how to improve on that. > Regarding this change specifically though, I'm unclear how it would > impact the things I push for others. I pushed some patches today, would > this mean that I'd have to look at what team/teams are involved > (according to /etc/teams.scm.in) for each commit/series, and then either > continue if I'm a member of that team, or skip it if I'm not? > > If I'm going to not be pushing stuff I would have previously pushed > because I'm not in the relevant teams, maybe I should just add myself to > every team? I guess this is not a serious question, but I'm more making > the point that if teams become a formal part of patch review, then some > formalities over membership of a team is probably a prerequsite. > > As a point of clarification, if a patch or series touches files that > fall within the scope of several teams, am I correct in saying that this > change would require approval from all teams? Good questions. For teams like =E2=80=98core=E2=80=99 or =E2=80=98home=E2=80=99, there shou= ld be no overlap, so it=E2=80=99s quite easy to see who=E2=80=99s in charge. Teams related to packages are more likely to overlap, and it=E2=80=99s also= an area where we generally want more flexibility. The example you give=E2=80=94pushing patches even though you=E2=80=99re not on the correspo= nding team(s)=E2=80=94is something we=E2=80=99d still want to allow most of the t= ime. There seems to be different requirements depending on teams. I=E2=80=99d l= ike more coordination and clearer responsibilities for subsystems (guix/*, gnu/{services,system,build}/*, etc.) and key packages/tools (Python, ocaml-build-system, etc.). For =E2=80=9Crandom packages=E2=80=9D, I=E2=80= =99m fine with the status quo. WDYT? Thanks, Ludo=E2=80=99.