From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 3/3] gnu: inkscape: New module Date: Tue, 04 Feb 2014 09:08:05 +0100 Message-ID: <87ppn3qp0a.fsf@gnu.org> References: <1391336858-4846-1-git-send-email-jmd@gnu.org> <1391336858-4846-3-git-send-email-jmd@gnu.org> <87a9e7opux.fsf@gnu.org> <20140204075440.GA25015@jocasta.intra> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48378) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAb86-0002xf-V8 for guix-devel@gnu.org; Tue, 04 Feb 2014 03:13:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WAb80-0000Cd-D8 for guix-devel@gnu.org; Tue, 04 Feb 2014 03:13:14 -0500 In-Reply-To: <20140204075440.GA25015@jocasta.intra> (John Darrington's message of "Tue, 4 Feb 2014 08:54:40 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: John Darrington Cc: guix-devel@gnu.org, John Darrington John Darrington skribis: > On Mon, Feb 03, 2014 at 10:20:22PM +0100, Ludovic Court??s wrote: > John Darrington skribis: >=20=20=20=20=20=20 > > * gnu/packages/inkscape.scm: New file > > * gnu-system.am: New file inkscape.scm >=20=20=20=20=20=20 > You forgot to add the patch file to ???gnu-system.am??? (also please= follow > the ChangeLog convention here.) > > Can you explain which bit of the changelog convention I haven't followed. I think it=E2=80=99s easily guessed by looking at previous commits or the G= CS. ;-) It should be: --8<---------------cut here---------------start------------->8--- * gnu/packages/inkscape.scm: New file. * gnu-system.am (GNU_SYSTEM_MODULES): Add inkscape.scm. --8<---------------cut here---------------end--------------->8--- Ludo=E2=80=99.