From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 1/2] dmd: Add dmd action unload: unload known services.
Date: Wed, 12 Mar 2014 18:45:28 +0100
Message-ID: <87pplrgvk7.fsf@gnu.org>
References: <87a9dcrzsh.fsf@gnu.org>
	<1394473161-14356-1-git-send-email-alex.sassmannshausen@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42566)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1WNnDq-0001Lv-EU
	for guix-devel@gnu.org; Wed, 12 Mar 2014 13:45:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1WNnDe-0006Fd-Pl
	for guix-devel@gnu.org; Wed, 12 Mar 2014 13:45:42 -0400
Received: from hera.aquilenet.fr ([2a01:474::1]:60429)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1WNnDe-0006F0-IL
	for guix-devel@gnu.org; Wed, 12 Mar 2014 13:45:30 -0400
In-Reply-To: <1394473161-14356-1-git-send-email-alex.sassmannshausen@gmail.com>
	(Alex Sassmannshausen's message of "Mon, 10 Mar 2014 18:39:20 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Alex Sassmannshausen <alex.sassmannshausen@gmail.com>
Cc: guix-devel@gnu.org

Alex Sassmannshausen <alex.sassmannshausen@gmail.com> skribis:

> * modules/dmd/service.scm (deregister-services): New procedure.
>   (dmd-service): Add new action: unload.
> * dmd.texi (The 'dmd' and 'unknown' services): Document 'unload'.
> * tests/basic.sh: Add 'unload' tests (stop single service  & 'all').

Applied with minor changes.

> +@item unload @var{service-name}
> +Attempt to remove the service identified by @var{service-name}.
> +@command{dmd} will first stop the service, if necessary, and then
> +remove it from the list of registered services.  Any services
> +depending upon @var{service-name} will be stopped as part of this
> +process.  If @var{service-name} simply does not exist, output a

I added a newline before =E2=80=9CIf=E2=80=9D so that the main info is more=
 easily
visible, and the paragraph is less intimidating.  ;-)

> +$deco unload dmd test
> +
> +$deco status dmd | grep "Stopped: (test-2)"
> +
> +$deco unload dmd all
> +
> +$deco status dmd | grep "Stopped: ()"

I added a test to make sure we get =E2=80=9CStarted: (dmd)=E2=80=9D.

Thanks!

Ludo=E2=80=99.