From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Bavier <ericbavier@gmail.com>
Subject: Re: [PATCH 01/13] gnu: subversion: Propagate env variables to hooks.
Date: Fri, 21 Nov 2014 16:24:12 -0600
Message-ID: <87ppcgtcoj.fsf@gmail.com>
References: <1416548468-28421-1-git-send-email-bavier@member.fsf.org>
	<1416548468-28421-2-git-send-email-bavier@member.fsf.org>
	<871towp5ze.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42370)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ericbavier@gmail.com>) id 1Xrwbe-0006lW-Cc
	for guix-devel@gnu.org; Fri, 21 Nov 2014 17:23:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ericbavier@gmail.com>) id 1XrwbY-0004Q5-Kx
	for guix-devel@gnu.org; Fri, 21 Nov 2014 17:23:10 -0500
In-reply-to: <871towp5ze.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org, Eric Bavier <bavier@member.fsf.org>


Ludovic Courtès writes:

> Eric Bavier <ericbavier@gmail.com> skribis:
>
>> * gnu/packages/patches/subversion-propagate-env-to-hooks.patch: New patch.
>> * gnu-system.am (dist_patch_DATA): Add it.
>> * gnu/packages/version-control.scm (subversion): Use it.
>
> [...]
>
>> +++ b/gnu/packages/patches/subversion-propagate-env-to-hooks.patch
>> @@ -0,0 +1,14 @@
>> +* Hooks need to inherit environment variables such as PATH, otherwise simple
>> +  things like `ls` might fail in a hook.
>
> What’s the upstream status of this patch?  I’m imagine it a useful
> property even for FHS distros.  IOW, what about submitting it upstream
> if it’s not already done?

It looks like they did change the behavior in 1.8.  I can't tell at this
point from the source if it would fix our use-case.  If it does, perhaps
we could upgrade our subversion to 1.8.10?

> That looks good, but I want to make sure we’re not changing something
> that was purposefully made this way.

If the behavior is similar in 1.8.10, I'll get in contact with the
developers.

-- 
Eric Bavier

Please avoid sending me Word or PowerPoint attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html