From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 2/4] gnu: Add xcffib
Date: Mon, 15 Dec 2014 23:16:38 +0100
Message-ID: <87ppbkeeyh.fsf@gnu.org>
References: <CAKrPhPOVuX_f+B1XCbEmHiKCCb7uODjcBRWVPkNvN9eOgHMvKA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52778)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Y0dwb-0007ms-DR
	for guix-devel@gnu.org; Mon, 15 Dec 2014 17:16:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Y0dwW-0007h1-KI
	for guix-devel@gnu.org; Mon, 15 Dec 2014 17:16:45 -0500
Received: from hera.aquilenet.fr ([2a01:474::1]:49194)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1Y0dwW-0007gx-Cs
	for guix-devel@gnu.org; Mon, 15 Dec 2014 17:16:40 -0500
In-Reply-To: <CAKrPhPOVuX_f+B1XCbEmHiKCCb7uODjcBRWVPkNvN9eOgHMvKA@mail.gmail.com>
	(Federico Beffa's message of "Sun, 14 Dec 2014 20:40:15 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Federico Beffa <beffa@ieee.org>
Cc: Guix-devel <guix-devel@gnu.org>

Federico Beffa <beffa@ieee.org> skribis:

> From f4187d31f95e3a65947d77bf267115906ed3816b Mon Sep 17 00:00:00 2001
> From: Federico Beffa <beffa@fbengineering.ch>
> Date: Wed, 10 Dec 2014 20:36:58 +0100
> Subject: [PATCH 2/4] gnu: Add xcffib
>
> * gnu/packages/python.scm (python-xcffib, python2-xcffib): New variables.

[...]

> +    (propagated-inputs
> +     `(("python-cffi" ,python-cffi)))

Please add a comment saying why this is propagated.

> +    (synopsis "XCB Python binding")

=E2=80=9Cbindings=E2=80=9D (plural)

> +    (description
> +     "A drop in replacement for xpyb, an XCB python binding.")

=E2=80=9Cdrop-in=E2=80=9D, =E2=80=9CPython=E2=80=9D, =E2=80=9Cbindings=E2=
=80=9D.

Could you expound the description a little bit?

The rest looks alright.

Thanks,
Ludo=E2=80=99.