From: ludo@gnu.org (Ludovic Courtès)
To: Federico Beffa <beffa@ieee.org>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH 2/4] gnu: Add xcffib
Date: Mon, 15 Dec 2014 23:16:38 +0100 [thread overview]
Message-ID: <87ppbkeeyh.fsf@gnu.org> (raw)
In-Reply-To: <CAKrPhPOVuX_f+B1XCbEmHiKCCb7uODjcBRWVPkNvN9eOgHMvKA@mail.gmail.com> (Federico Beffa's message of "Sun, 14 Dec 2014 20:40:15 +0100")
Federico Beffa <beffa@ieee.org> skribis:
> From f4187d31f95e3a65947d77bf267115906ed3816b Mon Sep 17 00:00:00 2001
> From: Federico Beffa <beffa@fbengineering.ch>
> Date: Wed, 10 Dec 2014 20:36:58 +0100
> Subject: [PATCH 2/4] gnu: Add xcffib
>
> * gnu/packages/python.scm (python-xcffib, python2-xcffib): New variables.
[...]
> + (propagated-inputs
> + `(("python-cffi" ,python-cffi)))
Please add a comment saying why this is propagated.
> + (synopsis "XCB Python binding")
“bindings” (plural)
> + (description
> + "A drop in replacement for xpyb, an XCB python binding.")
“drop-in”, “Python”, “bindings”.
Could you expound the description a little bit?
The rest looks alright.
Thanks,
Ludo’.
next prev parent reply other threads:[~2014-12-15 22:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-14 19:40 [PATCH 2/4] gnu: Add xcffib Federico Beffa
2014-12-15 22:16 ` Ludovic Courtès [this message]
2014-12-16 17:17 ` Federico Beffa
2014-12-17 9:01 ` Ludovic Courtès
2014-12-17 16:57 ` Federico Beffa
2014-12-17 20:28 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ppbkeeyh.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=beffa@ieee.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).