From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Subject: Re: [PATCH]: gnu: Add lash.
Date: Sat, 14 Feb 2015 00:14:52 +0100
Message-ID: <87pp9dmmj7.fsf@mango.localdomain>
References: <87sie9mp02.fsf@mango.localdomain> <87sie9e7rl.fsf@fsf.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38714)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1YMPRy-0006fF-Pm
	for guix-devel@gnu.org; Fri, 13 Feb 2015 18:15:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1YMPRt-0008F4-O2
	for guix-devel@gnu.org; Fri, 13 Feb 2015 18:15:06 -0500
Received: from pegasus.bbbm.mdc-berlin.de ([141.80.25.20]:50183)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1YMPRt-0008DP-F0
	for guix-devel@gnu.org; Fri, 13 Feb 2015 18:15:01 -0500
In-Reply-To: <87sie9e7rl.fsf@fsf.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: David Thompson <dthompson2@worcester.edu>
Cc: Guix-devel <guix-devel@gnu.org>


David Thompson writes:

>> +             (uri (string-append
>> +                   "mirror://savannah/lash/lash-"
>> +                   (string-map (lambda (x) (if (char=? x #\-) #\~ x)) version)
>
> How about splitting the string on #\- and then joining on #\~ instead?

Yeah, that would probably look better.  (I just adapted this from
another package without thinking much of it.)

>> +                   ".tar.bz2"))
>> +             (file-name (string-append name "-" version ".tar.gz"))
>
> The extension should be ".tar.bz2".

Ouch!  Good catch!

>> +             (sha256
>> +              (base32
>> +               "12z1vx3krrzsfccpah9xjs68900xvr7bw92wx8np5871i2yv47iw"))))
>> +    (build-system gnu-build-system)
>> +    (inputs
>> +     `(("bdb" ,bdb)
>> +       ("gtk" ,gtk+-2)
>> +       ("jack" ,jack-1)
>> +       ("libuuid" ,util-linux)
>> +       ("readline" ,readline)
>> +       ("python" ,python-2)))
>> +    (propagated-inputs
>> +     `(("alsa-lib" ,alsa-lib)
>> +       ("dbus" ,dbus)
>> +       ("libxml2" ,libxml2)))
>
> I'm always wary of propagated inputs, but I'll take your word for it. :)

I'm not sure I'm doing this right, but I noticed that in a package using
lash pkg-config complained about not being able to confirm a working
lash because of these three missing dependencies.  These are lash
dependencies that are listed in PC_REQUIRES.  As far as I can tell any
package dependent on lash would have to have at least these three
packages as inputs.  The complete list of PC_REQUIRES is this:

  dbus, libuuid, libxml2, alsa, jack

I would be happy if someone could confirm that this is how propagated
inputs are to be used, and if lash should propagate all five of these
inputs (instead of only the three here).

~~ Ricardo