From: Alex Kost <alezost@gmail.com>
To: Mathieu Lirzin <mthl@openmailbox.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/4] build: Produce 'guix-config' instead of using compile-time tricks.
Date: Wed, 29 Jul 2015 11:35:57 +0300 [thread overview]
Message-ID: <87pp3bl5si.fsf@gmail.com> (raw)
In-Reply-To: <1438033720-30958-3-git-send-email-mthl@openmailbox.org> (Mathieu Lirzin's message of "Mon, 27 Jul 2015 23:48:38 +0200")
Mathieu Lirzin (2015-07-28 00:48 +0300) wrote:
[...]
> +(defconst guix-prefix
> + "@prefix@")
> +
> +(defconst guix-emacs-ui-dir
> + "@emacsuidir@")
I think this constant is useless in this form since its value will be
"${prefix}/share/guile/site/2.0/guix/emacs". What about making it:
(defconst guix-emacs-ui-dir
(replace-regexp-in-string "${prefix}" guix-prefix "@emacsuidir@"))
And to leave:
(defvar guix-load-path guix-emacs-ui-dir
"Directory with scheme files for \"guix.el\" package.")
in "guix-backend.el"?
> +
> +(defconst guix-local-state-dir
> + "@guix_localstatedir@"oo)
> +
> +(provide 'guix-config)
> +
> +;;; guix-config.el ends here
> diff --git a/emacs/guix-init.el b/emacs/guix-init.el
> new file mode 100644
> index 0000000..353bb27
> --- /dev/null
> +++ b/emacs/guix-init.el
> @@ -0,0 +1,20 @@
> +(require 'guix-config)
I think requiring 'guix-config' is not needed in "guix-init.el".
The rest looks good to me.
--
Alex
next prev parent reply other threads:[~2015-07-29 8:36 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-27 21:48 [PATCH 0/4] Emacs Interface build system Mathieu Lirzin
2015-07-27 21:48 ` [PATCH 1/4] build: Add more variables to (guix config) Mathieu Lirzin
2015-07-29 8:35 ` Alex Kost
2015-08-06 17:38 ` Mathieu Lirzin
2015-08-18 15:15 ` Ludovic Courtès
2015-08-25 21:14 ` Mathieu Lirzin
2015-07-27 21:48 ` [PATCH 2/4] build: Produce 'guix-config' instead of using compile-time tricks Mathieu Lirzin
2015-07-27 21:56 ` Mathieu Lirzin
2015-07-29 8:35 ` Alex Kost [this message]
2015-08-06 17:50 ` Mathieu Lirzin
2015-08-13 8:04 ` Alex Kost
2015-08-25 21:16 ` Mathieu Lirzin
2015-08-26 10:51 ` Alex Kost
2015-08-30 17:55 ` Mathieu Lirzin
2015-08-30 19:03 ` Alex Kost
2015-07-27 21:48 ` [PATCH 3/4] emacs: Move guix-guile-program to 'guix-config' Mathieu Lirzin
2015-07-29 8:36 ` Alex Kost
2015-08-06 17:55 ` Mathieu Lirzin
2015-08-07 7:21 ` Alex Kost
2015-08-25 21:18 ` Mathieu Lirzin
2015-08-30 17:32 ` Ludovic Courtès
2015-08-30 19:03 ` Alex Kost
2015-08-30 20:54 ` Mathieu Lirzin
2015-07-27 21:48 ` [PATCH 4/4] emacs: Use only one guix-load-path variable Mathieu Lirzin
2015-07-29 8:36 ` Alex Kost
2015-08-06 17:58 ` Mathieu Lirzin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pp3bl5si.fsf@gmail.com \
--to=alezost@gmail.com \
--cc=guix-devel@gnu.org \
--cc=mthl@openmailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).