unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: Daniel Pimentel <d4n1@openmailbox.org>
Cc: guix-devel@gnu.org, guix-devel-bounces+d4n1=opmbx.org@gnu.org
Subject: Re: [PATCH] Update enlightenment.scm: Add Rage Player
Date: Thu, 06 Aug 2015 16:24:22 +0200	[thread overview]
Message-ID: <87pp30pka1.fsf@elephly.net> (raw)
In-Reply-To: <7c16d9a37b86038dfbb836b31bd7c8e6@openmailbox.org>

Thanks for the updated patch!

> * gnu/packages/enlightenment.scm: Add Rage.

This should really be:

    * gnu/packages/enlightenment.scm (rage): New variable.

Other than that I have no important objections.  I think this looks ugly
and could be improved, but I don’t think it’s very important:

> +              (uri
> +               (string-append
> +                "http://download.enlightenment.org/rel/apps/rage/rage-"
> +                version ".tar.gz"))

I’d put “(uri (string-append ...” on the same line, pull part of the
string onto the same line and align the rest accordingly.

But I better leave the comments and the final decision to someone else.

~~ Ricardo

  reply	other threads:[~2015-08-06 14:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-05 13:38 [PATCH] Update enlightenment.scm: Add Rage Player Daniel Pimentel
2015-08-05 13:59 ` Thompson, David
2015-08-05 14:08   ` Daniel Pimentel
2015-08-05 14:11 ` Ricardo Wurmus
2015-08-05 14:27   ` Daniel Pimentel
2015-08-05 14:31     ` Ricardo Wurmus
2015-08-05 14:35       ` Daniel Pimentel
2015-08-06 14:16         ` Daniel Pimentel
2015-08-06 14:24           ` Ricardo Wurmus [this message]
2015-08-06 14:33             ` Daniel Pimentel
2015-08-18 16:51           ` Ludovic Courtès
2015-08-18 18:28             ` Daniel Pimentel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pp30pka1.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=d4n1@openmailbox.org \
    --cc=guix-devel-bounces+d4n1=opmbx.org@gnu.org \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).