unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Mark H Weaver <mhw@netris.org>
To: ericbavier@openmailbox.org
Cc: guix-devel@gnu.org, Eric Bavier <bavier@member.fsf.org>
Subject: Re: [PATCH] guix: lint: Check for version-only origin file names.
Date: Mon, 24 Aug 2015 19:02:11 -0400	[thread overview]
Message-ID: <87pp2cmgss.fsf@netris.org> (raw)
In-Reply-To: <1440371134-2699-1-git-send-email-ericbavier@openmailbox.org> (ericbavier@openmailbox.org's message of "Sun, 23 Aug 2015 18:05:34 -0500")

ericbavier@openmailbox.org writes:

> From: Eric Bavier <bavier@member.fsf.org>
>
> * guix/scripts/lint.scm (check-source): Emit warning if source filename
>   contains only the version of the package.

This is not a proper review, but I just wanted to add that another
common case is for the filename to start with "v" followed by the
version number, e.g. "v3.2.0.tar.gz", so it would be good to check for
that too.  If you search for the string '/v"' in gnu/packages/*.scm
you'll find a great many examples.

Thank you for working on it!

       Mark

  reply	other threads:[~2015-08-24 23:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-23 23:05 [PATCH] guix: lint: Check for version-only origin file names ericbavier
2015-08-24 23:02 ` Mark H Weaver [this message]
2015-08-25  0:10   ` Eric Bavier
2015-08-28  7:48     ` Ludovic Courtès
2015-09-10 20:50       ` Eric Bavier
2015-09-11  4:04         ` Eric Bavier
2015-09-13 16:59           ` Ludovic Courtès
2015-09-14 23:11             ` Eric Bavier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pp2cmgss.fsf@netris.org \
    --to=mhw@netris.org \
    --cc=bavier@member.fsf.org \
    --cc=ericbavier@openmailbox.org \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).