From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] Fix h5py.
Date: Thu, 08 Oct 2015 13:52:03 +0200
Message-ID: <87pp0ptw64.fsf@gnu.org>
References: <idj37xl37pv.fsf@bimsb-sys02.mdc-berlin.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37063)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Zk9k3-0007cZ-KF
	for guix-devel@gnu.org; Thu, 08 Oct 2015 07:52:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Zk9jz-0006a8-Hq
	for guix-devel@gnu.org; Thu, 08 Oct 2015 07:52:11 -0400
In-Reply-To: <idj37xl37pv.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's
	message of "Thu, 8 Oct 2015 13:44:44 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: Guix-devel <guix-devel@gnu.org>

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> python-h5py is currently broken.
>
>    guix environment --ad-hoc python-2.7.10 python2-h5py
>    python
>    >>> import h5py
>    [weird error]
>
> The immediate reason here is that an Egg archive is built and installed
> instead of a directory.  Python doesn=E2=80=99t seem to know how to import
> modules whose contents are trapped in an Egg archive (or is this only
> the case when setuptools are not in the profile?).
>
> I found that removing =E2=80=98python-setuptools=E2=80=99 from the =E2=80=
=98native-inputs=E2=80=99 field
> changes the behaviour such that no Egg archive is built and the library
> files are installed plainly.

OK.  We=E2=80=99ll have to see if other packages are affected.

> Another problem with h5py was that it didn=E2=80=99t actually build again=
st our
> hdf5 library, because it looked for the library and the headers under
> =E2=80=98/opt/local=E2=80=99 and =E2=80=98/usr/local=E2=80=99.  I fixed t=
his by adding an additional
> build phase.

Not shown here, right?

> From 5f368af582d3586a7b4e3a353d9bbd75eeb83a61 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Thu, 8 Oct 2015 13:30:23 +0200
> Subject: [PATCH 1/2] gnu: python-h5py, python2-h5py: Correct inputs.
>
> * gnu/packages/python.scm (python-h5py)
>   [inputs]: Remove python-cython and python-numpy.
>   [propagated-inputs]: New field.
>   [native-inputs]: Drop python-setuptools and add python-cython.
>   (python2-h5py): Replace "inputs" with "propagated-inputs".

I=E2=80=99m no expert but it makes sense to me.  The commit log is OK.

Thanks!

Ludo=E2=80=99.