From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paul van der Walt <paul@denknerd.org>
Subject: Re: [PATCH 18/43] gnu: ghc-async: New variable.
Date: Tue, 20 Oct 2015 15:42:03 +0200
Message-ID: <87pp094pxw.fsf@denknerd.org>
References: <1444911697-15515-1-git-send-email-paul@denknerd.org>
	<1444911697-15515-18-git-send-email-paul@denknerd.org>
	<20151019090836.539cc1a2@openmailbox.org>
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57763)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paul@denknerd.org>) id 1ZoXB8-0005b8-PF
	for guix-devel@gnu.org; Tue, 20 Oct 2015 09:42:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paul@denknerd.org>) id 1ZoXB3-0004r4-7F
	for guix-devel@gnu.org; Tue, 20 Oct 2015 09:42:14 -0400
Received: from mx01.mykolab.com ([95.128.36.1]:16069 helo=mx-out02.mykolab.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paul@denknerd.org>) id 1ZoXB3-0004qr-0V
	for guix-devel@gnu.org; Tue, 20 Oct 2015 09:42:09 -0400
In-reply-to: <20151019090836.539cc1a2@openmailbox.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Eric Bavier <ericbavier@openmailbox.org>
Cc: guix-devel@gnu.org


On 2015-10-19 at 16:08, quoth Eric Bavier:
>> +    (arguments `(#:tests? #f)) ; FIXME: testing libraries are missing.
>
> If this is the case, can the "ghc-hunit" input be left out?

It seems so.  It compiles without.  Fixed.

>> +    (home-page "https://github.com/simonmar/async")
>> +    (synopsis "Run IO operations asynchronously and wait for their results")
>> +    (description "Higher-level interface over threads in Haskell, in which
>> +Async a is a concurrent thread that will eventually deliver a value of type
>> +a.")
>
> The first sentence here is a fragment.  Also, I believe our new texinfo
> support could come in handy here (and in other haskell packages, as
> they seem to like including code fragments):
>
> "This package provides a higher-level interface over threads in
> Haskell, in which @code{Async a} is a concurrent thread that will
> eventually deliver a value of type @code{a}."

All fixed.