unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Mathieu Lirzin <mthl@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] gnu: rxvt-unicode: Add the terminal capability data.
Date: Thu, 10 Dec 2015 03:57:16 +0100	[thread overview]
Message-ID: <87poyfhuyb.fsf@gnu.org> (raw)
In-Reply-To: <87zixjl4w8.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Wed, 09 Dec 2015 21:54:15 +0100")

ludo@gnu.org (Ludovic Courtès) writes:

> Mathieu Lirzin <mthl@gnu.org> skribis:
[...]
>> +    (native-search-paths
>> +     (list (search-path-specification
>> +            (variable "TERMINFO_DIRS")
>> +            (files '("share/terminfo")))))
>
> This should be in the ncurses package itself, since it is “owned” by
> ncurses, not rxvt.
>
> However, there’s the limitation that, currently, --search-paths
> advertises the variables of things that are explicitly in the profile.
> Ncurses is usually not in the profile; it is a dependency of something
> that is in the profile.  Thus, people wouldn’t see anything about
> TERMINFO_DIRS in practice (we have the same problem with OpenSSL,
> GStreamer, and other librairies that have associated variables.)
>
> Long story short, I would avoid adding this ‘native-search-paths’ here,
> but I’m OK with it since that would make the thing usable, provided
> there’s a big FIXME in there.
>
> WDYT?

It makes sense.  Since it is quite complicated, what about creating a
bug report explaining the problem and make the comment refer to it like
this:

  ;; FIXME: This is not located in `ncurses' for usability reasons.  See
  ;; https://debbugs.gnu.org/cgi/bugreport.cgi?bug=XXXXX

WDYT?  Can you take care of creating the bug report or propose an
appropriate FIXME comment?  I don't feel up to explaining this myself.

Thanks,

--
Mathieu Lirzin

  parent reply	other threads:[~2015-12-10  2:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-08 17:18 [PATCH] gnu: rxvt-unicode: Add the terminal capability data Mathieu Lirzin
2015-12-09  3:24 ` Leo Famulari
2015-12-09 14:12   ` Mathieu Lirzin
2015-12-09 13:52 ` Ludovic Courtès
2015-12-09 17:58   ` Mathieu Lirzin
2015-12-09 20:54     ` Ludovic Courtès
2015-12-09 21:26       ` Leo Famulari
2015-12-10  3:21         ` Mathieu Lirzin
2015-12-10  2:57       ` Mathieu Lirzin [this message]
2015-12-10  9:42         ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87poyfhuyb.fsf@gnu.org \
    --to=mthl@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).