Re: [PATCH 03/04] gnu: Add python2-xdo

[Christopher Allan Webber <cwebber@dustycloud.org>]

[-- Attachment #1: Type: text/plain, Size: 2284 bytes --]

Leo Famulari writes:

> On Fri, Feb 05, 2016 at 07:48:59PM -0800, Christopher Allan Webber wrote:
>> * gnu/packages/python.scm (python2-xdo): New variable.
>
> [...]
>
>> +    (source (origin
>> +              (method url-fetch)
>> +              (uri (string-append
>> +                    "http://http.debian.net/debian/pool/main/p/python-xdo/python-xdo_"
>
> If this line is longer than 80 characters, please split the string onto
> the next line.

Fixed, yeah, sorry!

>> +                    version ".orig.tar.gz"))
>> +              (sha256
>> +               (base32
>> +                "1kl5c1p0dyxf62plnk6fl77ycfb4whwjms16r14dxx8kn90hlqz4"))))
>> +    (build-system python-build-system)
>> +    (arguments
>> +     `(#:python ,python-2
>> +       #:tests? #f))  ; no tests provided
>> +    (inputs
>> +     `(("xdotool" ,xdotool)
>> +       ("libX11" ,libx11)))
>> +    (home-page "https://tracker.debian.org/pkg/python-xdo")
>
> Is it developed within Debian? Interesting if so!

The main developer is a Debian author, and there's no formal page, so
this seemed like the best one.  He has his own git repository and then
just packages straight for Debian.  This is the best http-accessible
page for describing things I could find!

>> +    (synopsis "Python library for simulating X11 keyboard/mouse input (libxdo bindings)")
>
> Line length? The linter should complain if the synopsis is too long.

Ok, I just dropped the (libxdo bindings), which is probably obvious, and
an interested reader can check the description anyway.

>> +    ;; Note about this being a legacy
>
> Did you mean to leave this comment in? ;)
>
>> +    (description "Provides bindings to libxdo for manipulating X11 via simulated
>> +input.  (Note that this is mostly a legacy library; you may wish to look at
>> +python-xdo for newer bindings.)")
>
> I see, so this is a python-2 specific legacy package?

Yes... so there's another one, python-libxdo, and I have it
half-packaged locally.  The python-xdo author (also the assword author)
is currently using python-xdo, but is encouraging use of python-libxdo
for the future, and assword may move to that soon too.  I'll package
that, and we can drop python-xdo probably, once assword moves to
python-libxdo.

Anyway, new patch attached!

 - Chris


[-- Attachment #2: 0003-gnu-Add-python2-xdo.patch --]
[-- Type: text/x-patch, Size: 2528 bytes --]

From 85bc38e6682bf8892243d627c4beec7b1a9f521a Mon Sep 17 00:00:00 2001
From: Christopher Allan Webber <cwebber@dustycloud.org>
Date: Fri, 5 Feb 2016 19:07:11 -0800
Subject: [PATCH 2/3] gnu: Add python2-xdo

* gnu/packages/python.scm (python2-xdo): New variable.
---
 gnu/packages/python.scm | 30 +++++++++++++++++++++++++++++-
 1 file changed, 29 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 48f65b5..1dc74ef 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -8,7 +8,7 @@
 ;;; Copyright © 2015 Omar Radwan <toxemicsquire4@gmail.com>
 ;;; Copyright © 2015 Pierre-Antoine Rault <par@rigelk.eu>
 ;;; Copyright © 2015 Ricardo Wurmus <rekado@elephly.net>
-;;; Copyright © 2015 Christopher Allan Webber <cwebber@dustycloud.org>
+;;; Copyright © 2015, 2016 Christopher Allan Webber <cwebber@dustycloud.org>
 ;;; Copyright © 2015 Eric Dvorsak <eric@dvorsak.fr>
 ;;; Copyright © 2015, 2016 David Thompson <davet@gnu.org>
 ;;; Copyright © 2015, 2016 Leo Famulari <leo@famulari.name>
@@ -72,6 +72,7 @@
   #:use-module (gnu packages base)
   #:use-module (gnu packages xml)
   #:use-module (gnu packages xorg)
+  #:use-module (gnu packages xdisorg)
   #:use-module (gnu packages zip)
   #:use-module (gnu packages tcl)
   #:use-module (guix packages)
@@ -7498,3 +7499,30 @@ normally the case.")
 
 (define-public python2-pytest-subtesthack
   (package-with-python2 python-pytest-subtesthack))
+
+(define-public python2-xdo
+  (package
+    (name "python2-xdo")
+    (version "0.2")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "http://http.debian.net/debian/pool/main/p/python-xdo/"
+                    "python-xdo_" version ".orig.tar.gz"))
+              (sha256
+               (base32
+                "1kl5c1p0dyxf62plnk6fl77ycfb4whwjms16r14dxx8kn90hlqz4"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:python ,python-2
+       #:tests? #f))  ; no tests provided
+    (inputs
+     `(("xdotool" ,xdotool)
+       ("libX11" ,libx11)))
+    (home-page "https://tracker.debian.org/pkg/python-xdo")
+    (synopsis "Python library for simulating X11 keyboard/mouse input")
+    (description "Provides bindings to libxdo for manipulating X11 via simulated
+input.  (Note that this is mostly a legacy library; you may wish to look at
+python-xdo for newer bindings.)")
+    (license bsd-3)))
+
-- 
2.6.3