unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Roel Janssen <roel@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add nlopt.
Date: Tue, 03 May 2016 22:17:29 +0200	[thread overview]
Message-ID: <87pot2zyjq.fsf@gnu.org> (raw)
In-Reply-To: <87futylxk6.fsf@gnu.org>


Ludovic Courtès writes:

> Roel Janssen <roel@gnu.org> skribis:
>
>> I added your magic for Guile.  Here is the patch:
>>
>>From 6221baadea331cff7e8ab6b9ea1b3bb7737b227f Mon Sep 17 00:00:00 2001
>> From: Roel Janssen <roel@gnu.org>
>> Date: Tue, 3 May 2016 14:30:25 +0200
>> Subject: [PATCH] gnu: Add nlopt.
>>
>> * gnu/packages/maths.scm (nlopt): New variable.
>
> Pushed with minor cosmetic changes, notably:
>
>> +    (source (origin
>> +      (method url-fetch)
>> +      (uri (string-append "http://ab-initio.mit.edu/nlopt/nlopt-"
>> +                          version ".tar.gz"))
>> +      (sha256
>> +       (base32 "12cfkkhcdf4zmb6h7y6qvvdvqjs2xf9sjpa3rl3bq76px4yn76c0"))))
>
> “(method” should be indented below the “r” of “origin” (I think this
> pattern also appears in the R patches you recently submitted.)
>
> Thank you!

I've been submitting most packages this way.  Should I align (method
...) to the r in origin for all packages in the future?

Thank you!

Kind regards,
Roel Janssen

  reply	other threads:[~2016-05-03 20:18 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-07 11:26 [PATCH] gnu: Add nlopt Roel Janssen
2016-04-07 15:44 ` Leo Famulari
2016-04-07 20:42   ` Alex Kost
2016-04-07 20:49   ` Roel Janssen
2016-04-08 10:18     ` Mathieu Lirzin
2016-04-09  5:56       ` Leo Famulari
2016-04-09 10:54         ` Mathieu Lirzin
2016-04-09 16:21           ` Leo Famulari
2016-04-07 20:48 ` Alex Kost
2016-04-07 21:20   ` Roel Janssen
2016-04-07 21:40 ` Ludovic Courtès
2016-04-07 22:52   ` Roel Janssen
2016-04-09 14:38     ` Ludovic Courtès
2016-05-03 11:02       ` Roel Janssen
2016-05-03 11:47         ` Ludovic Courtès
2016-05-03 12:34           ` Roel Janssen
2016-05-03 20:02             ` Ludovic Courtès
2016-05-03 20:17               ` Roel Janssen [this message]
2016-05-04  8:38                 ` Alex Kost
2016-05-04  8:52                   ` Roel Janssen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pot2zyjq.fsf@gnu.org \
    --to=roel@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).