Andy Wingo writes:

Hi Andy,

What I meant to say in my first mail, I'll do in the last.  Thanks so
much again for this round of reviews!  It took me quite some rebuilds
to get sane answers to your remarks and there were some bugs that I
needed to get straightened out first, that's why I could not answer
sooner.

>> -   (native-inputs `(("pkgconfig" ,pkg-config)))
>> +   (native-inputs `(("pkgconfig" ,pkg-config)
>> +                    ,@(if (mingw-target?) `(("bash" ,bash)) '())))
>
> AFAIU we can remove the "bash" thing here, as we decided to punt on
> (ice-9 popen); sound right to you?

Indeed.  Tested without this addition and removed.  (This is about the
native, build-hosts' bash anyway.  I think including the build host bash
explicitly may have been necessary when I was creating the cross-build.)

>> +                       (if bash
>> +                           (string-append bash "/bin/bash")
>> +                           "bash")))))
>
> Needs a comment here explaining that although we should always have bash
> as an input, it isn't packaged yet on mingw so we are falling back to
> finding it in the run-time path if needed.

Added this comment

          ;; If bash is #f allow fallback for user to provide
          ;; "bash" in PATH.  This happens when cross-building to
          ;; MinGW for which we do not have Bash yet.
          (("/bin/sh")
           (if bash
               (string-append bash "/bin/bash")
               "bash")))))

> FWIW although Windows doesn't support `fork', `open-process' should work
> in Windows, and we should therefore be able to get (ice-9 popen) working
> in Windows eventually.

Yes, I agree.
Greetings, Jan