[PATCH 0/1] Grafting problem with libxml2

[PATCH 0/1] Grafting problem with libxml2

[Leo Famulari]

In 493e9a5a8f we fixed some bugs in libxml2 with a graft. Later, I
couldn't reconfigure my GuixSD system, due to an error like this:

ERROR: invalid replacement
"/gnu/store/3szw4bvhlm0pv9fm6vhmzzdj64d7gvr6-python2-libxml2-2.9.3"
"/gnu/store/5pp4pv6k8hhx2fgx62d40c028lszr8ga-libxml2-2.9.3"

Python-libxml2 inherits from libxml2, so it seems that it needs
(replacement #f), as in this patch.

With this patch, I can reconfigure my system. Also, python-libxml2 does
refer to the grafted libxml2, as expected:

$ ./pre-inst-env guix build --no-grafts libxml2
/gnu/store/7lxgrhmfgdd303gslaxazmmdv6n1nf77-libxml2-2.9.3

$ ./pre-inst-env guix build libxml2
/gnu/store/5pp4pv6k8hhx2fgx62d40c028lszr8ga-libxml2-2.9.3

$ guix gc --references $(./pre-inst-env guix build python-libxml2)
/gnu/store/5pp4pv6k8hhx2fgx62d40c028lszr8ga-libxml2-2.9.3
/gnu/store/8m00x5x8ykmar27s9248cmhnkdb2n54a-glibc-2.22
/gnu/store/9vjcfcmyi549hpkyqrasz507rwc388xx-python-3.4.3
/gnu/store/d97bqdh5ackjfv0zhmkcb169c0gryywh-python-libxml2-2.9.3
/gnu/store/hsxhfmjgh8m4c0pavq3gd3gcrn8zrgxj-zlib-1.2.8
/gnu/store/v39bh3ln3ncnzhyw0kd12d46kww9747v-gcc-4.9.3-lib

It seems like the right thing to do to me. What do you think?

Leo Famulari (1):
  gnu: python-libxml2: Don't use as replacement for libxml2.

 gnu/packages/xml.scm | 1 +
 1 file changed, 1 insertion(+)

-- 
2.8.3

[PATCH 1/1] gnu: python-libxml2: Don't use as replacement for libxml2.

[Leo Famulari]

This is a followup to commit 493e9a5a8f613764cfa396c33ee6cb381b0dbbef.

* gnu/packages/xml.scm (python-libxml2, python2-libxml2)[replacement]:
New field.
---
 gnu/packages/xml.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/xml.scm b/gnu/packages/xml.scm
index 96bb8b7..782e356 100644
--- a/gnu/packages/xml.scm
+++ b/gnu/packages/xml.scm
@@ -115,6 +115,7 @@ project (but it is usable outside of the Gnome platform).")
 (define-public python-libxml2
   (package (inherit libxml2)
     (name "python-libxml2")
+    (replacement #f)
     (build-system python-build-system)
     (arguments
      `(;; XXX: Tests are specified in 'Makefile.am', but not in 'setup.py'.
-- 
2.8.3

Re: [PATCH 1/1] gnu: python-libxml2: Don't use as replacement for libxml2.

[Mark H Weaver]

Hi,

Leo Famulari <leo@famulari.name> writes:

> This is a followup to commit 493e9a5a8f613764cfa396c33ee6cb381b0dbbef.
>
> * gnu/packages/xml.scm (python-libxml2, python2-libxml2)[replacement]:
> New field.
> ---
>  gnu/packages/xml.scm | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/gnu/packages/xml.scm b/gnu/packages/xml.scm
> index 96bb8b7..782e356 100644
> --- a/gnu/packages/xml.scm
> +++ b/gnu/packages/xml.scm
> @@ -115,6 +115,7 @@ project (but it is usable outside of the Gnome platform).")
>  (define-public python-libxml2
>    (package (inherit libxml2)
>      (name "python-libxml2")
> +    (replacement #f)
>      (build-system python-build-system)
>      (arguments
>       `(;; XXX: Tests are specified in 'Makefile.am', but not in 'setup.py'.

I noticed the same problem, and pushed the same fix, before seeing this
message.  Thanks anyway!

      Mark

Re: [PATCH 0/1] Grafting problem with libxml2

[Ludovic Courtès]

Leo Famulari <leo@famulari.name> skribis:

> In 493e9a5a8f we fixed some bugs in libxml2 with a graft. Later, I
> couldn't reconfigure my GuixSD system, due to an error like this:
>
> ERROR: invalid replacement
> "/gnu/store/3szw4bvhlm0pv9fm6vhmzzdj64d7gvr6-python2-libxml2-2.9.3"
> "/gnu/store/5pp4pv6k8hhx2fgx62d40c028lszr8ga-libxml2-2.9.3"
>
> Python-libxml2 inherits from libxml2, so it seems that it needs
> (replacement #f), as in this patch.

Good catch!  I see Mark committed the same thing as
92a7e46d58c59953cc4b35dcd1413ebfc0de8ec0, so thanks to both of you.

Ludo’.