unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: Trying to build latest Icedtea / Java 6 [security update]
Date: Tue, 31 May 2016 21:13:04 +0200	[thread overview]
Message-ID: <87pos2ca7z.fsf@elephly.net> (raw)
In-Reply-To: <20160530045937.GA32652@jasmine>


Leo Famulari <leo@famulari.name> writes:

> Icedtea 1.13.11 was released, which fixes a number of security bugs:
>
> http://blog.fuseyism.com/index.php/2016/05/04/security-icedtea-1-13-11-for-openjdk-6-released/
>
> I tried to build it with the attached patch, but it fails for me. I've
> attached the tail of the build log. Any advice?

The patch looks good to me.  If I understand correctly this may be
because we’re bootstrapping with GCJ, which implements Java 1.5.  You
can see in the log that “javac” runs with “-source 1.5 -target 5”, which
means that it assumes that the code is written in compliance with Java
1.5.  Maybe this file simply is not valid Java 1.5.

According to http://stackoverflow.com/a/8697805/519736 “@Override” is
interpreted more strictly in 1.5.  I don’t know much about Java and I
haven’t looked at the sources in question, but I guess there are
“@Override” annotations above the five method declarations.  We might be
able to just remove them.

I think this should be reported to Andrew; looks like a bug as
bootstrapping with GCJ should work for OpenJDK 6.

~~ Ricardo

  reply	other threads:[~2016-05-31 19:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-30  4:59 Trying to build latest Icedtea / Java 6 [security update] Leo Famulari
2016-05-31 19:13 ` Ricardo Wurmus [this message]
2016-05-31 22:52   ` Leo Famulari
2016-06-01  6:07     ` Ricardo Wurmus
2016-06-01  6:29       ` Leo Famulari
2016-06-16  2:02         ` Danny Milosavljevic
2016-06-16  6:55           ` Ricardo Wurmus
2016-07-20 22:13             ` IcedTea Java 8 font problems Danny Milosavljevic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pos2ca7z.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=guix-devel@gnu.org \
    --cc=leo@famulari.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).