unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH] gnu: Add emacs-company.
@ 2016-06-17  6:12 Ricardo Wurmus
  2016-06-17  6:20 ` Ben Woodcroft
  0 siblings, 1 reply; 5+ messages in thread
From: Ricardo Wurmus @ 2016-06-17  6:12 UTC (permalink / raw)
  To: guix-devel

* gnu/packages/emacs.scm (emacs-company): New variable.
---
 gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index cb6464d..e4b3097 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1333,6 +1333,30 @@ view the build status of those servers' build jobs, and possibly to trigger
 build jobs.")
     (license license:gpl3+)))
 
+(define-public emacs-company
+  (package
+    (name "emacs-company")
+    (version "0.8.12")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "http://elpa.gnu.org/packages/company-"
+                           version ".tar"))
+       (sha256
+        (base32
+         "1r7q813rjs4dgknsfqi354ahsvk8k4ld4xh1fkp8lbxb13da6gqx"))))
+    (build-system emacs-build-system)
+    ;; The tests cannot be built because the file "company-tests" is not part
+    ;; of the tarball.
+    (home-page "http://company-mode.github.io/")
+    (synopsis "Modular text completion framework")
+    (description
+     "Company is a modular completion mechanism.  Modules for retrieving
+completion candidates are called back-ends, modules for displaying them are
+front-ends.  Company comes with many back-ends, e.g. `company-elisp'.  These
+are distributed in separate files and can be used individually.")
+    (license license:gpl3+)))
+
 (define-public typo
   (package
     (name "emacs-typo")
-- 
2.8.3

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] gnu: Add emacs-company.
  2016-06-17  6:12 [PATCH] gnu: Add emacs-company Ricardo Wurmus
@ 2016-06-17  6:20 ` Ben Woodcroft
  2016-06-17  7:23   ` Ricardo Wurmus
  0 siblings, 1 reply; 5+ messages in thread
From: Ben Woodcroft @ 2016-06-17  6:20 UTC (permalink / raw)
  To: Ricardo Wurmus, guix-devel



On 17/06/16 16:12, Ricardo Wurmus wrote:
> * gnu/packages/emacs.scm (emacs-company): New variable.
> ---
>   gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++
>   1 file changed, 24 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index cb6464d..e4b3097 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -1333,6 +1333,30 @@ view the build status of those servers' build jobs, and possibly to trigger
>   build jobs.")
>       (license license:gpl3+)))
>   
> +(define-public emacs-company
> +  (package
> +    (name "emacs-company")
> +    (version "0.8.12")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "http://elpa.gnu.org/packages/company-"
> +                           version ".tar"))
> +       (sha256
> +        (base32
> +         "1r7q813rjs4dgknsfqi354ahsvk8k4ld4xh1fkp8lbxb13da6gqx"))))
> +    (build-system emacs-build-system)
> +    ;; The tests cannot be built because the file "company-tests" is not part
> +    ;; of the tarball.

It is part of the GitHub releases though e.g. at
https://github.com/company-mode/company-mode/tree/e085a333867959a1b36015a3ad8e12e5bd6550d9

Would it make sense to source from GitHub instead?

ben

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] gnu: Add emacs-company.
  2016-06-17  6:20 ` Ben Woodcroft
@ 2016-06-17  7:23   ` Ricardo Wurmus
  2016-06-17 15:10     ` Ludovic Courtès
  0 siblings, 1 reply; 5+ messages in thread
From: Ricardo Wurmus @ 2016-06-17  7:23 UTC (permalink / raw)
  To: Ben Woodcroft; +Cc: guix-devel

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]


Ben Woodcroft <b.woodcroft@uq.edu.au> writes:

> On 17/06/16 16:12, Ricardo Wurmus wrote:
[...]
>> +    ;; The tests cannot be built because the file "company-tests" is not part
>> +    ;; of the tarball.
>
> It is part of the GitHub releases though e.g. at
> https://github.com/company-mode/company-mode/tree/e085a333867959a1b36015a3ad8e12e5bd6550d9
>
> Would it make sense to source from GitHub instead?

Yes, thanks for the pointer.  Here’s a new patch.

~~ Ricardo


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-emacs-company.patch --]
[-- Type: text/x-patch, Size: 1639 bytes --]

From a4e0f28d8d77002d9f4907418190531b508ebca6 Mon Sep 17 00:00:00 2001
From: Ricardo Wurmus <rekado@elephly.net>
Date: Fri, 17 Jun 2016 08:11:49 +0200
Subject: [PATCH] gnu: Add emacs-company.

* gnu/packages/emacs.scm (emacs-company): New variable.
---
 gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index cb6464d..a80d9ce 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1333,6 +1333,29 @@ view the build status of those servers' build jobs, and possibly to trigger
 build jobs.")
     (license license:gpl3+)))
 
+(define-public emacs-company
+  (package
+    (name "emacs-company")
+    (version "0.8.12")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/company-mode/company-mode/archive/"
+                           version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "1vwmbqm7h4lrszv2qxy6fqzznm9raigi84cadx982c9m7shp0zzz"))))
+    (build-system emacs-build-system)
+    (home-page "http://company-mode.github.io/")
+    (synopsis "Modular text completion framework")
+    (description
+     "Company is a modular completion mechanism.  Modules for retrieving
+completion candidates are called back-ends, modules for displaying them are
+front-ends.  Company comes with many back-ends, e.g. `company-elisp'.  These
+are distributed in separate files and can be used individually.")
+    (license license:gpl3+)))
+
 (define-public typo
   (package
     (name "emacs-typo")
-- 
2.8.3


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] gnu: Add emacs-company.
  2016-06-17  7:23   ` Ricardo Wurmus
@ 2016-06-17 15:10     ` Ludovic Courtès
  2016-06-17 19:19       ` Ricardo Wurmus
  0 siblings, 1 reply; 5+ messages in thread
From: Ludovic Courtès @ 2016-06-17 15:10 UTC (permalink / raw)
  To: Ricardo Wurmus; +Cc: guix-devel

Ricardo Wurmus <rekado@elephly.net> skribis:

> From a4e0f28d8d77002d9f4907418190531b508ebca6 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Fri, 17 Jun 2016 08:11:49 +0200
> Subject: [PATCH] gnu: Add emacs-company.
>
> * gnu/packages/emacs.scm (emacs-company): New variable.

[...]

> +     "Company is a modular completion mechanism.  Modules for retrieving
> +completion candidates are called back-ends, modules for displaying them are
> +front-ends.  Company comes with many back-ends, e.g. `company-elisp'.  These

@code{company-elisp}

Otherwise LGTM, thanks!

Ludo’.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] gnu: Add emacs-company.
  2016-06-17 15:10     ` Ludovic Courtès
@ 2016-06-17 19:19       ` Ricardo Wurmus
  0 siblings, 0 replies; 5+ messages in thread
From: Ricardo Wurmus @ 2016-06-17 19:19 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: guix-devel


Ludovic Courtès <ludo@gnu.org> writes:

> Ricardo Wurmus <rekado@elephly.net> skribis:
>
>> From a4e0f28d8d77002d9f4907418190531b508ebca6 Mon Sep 17 00:00:00 2001
>> From: Ricardo Wurmus <rekado@elephly.net>
>> Date: Fri, 17 Jun 2016 08:11:49 +0200
>> Subject: [PATCH] gnu: Add emacs-company.
>>
>> * gnu/packages/emacs.scm (emacs-company): New variable.
>
> [...]
>
>> +     "Company is a modular completion mechanism.  Modules for retrieving
>> +completion candidates are called back-ends, modules for displaying them are
>> +front-ends.  Company comes with many back-ends, e.g. `company-elisp'.  These
>
> @code{company-elisp}

Right.  Fixed it and pushed to master.

Thanks!

~~ Ricardo

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-06-17 19:19 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-17  6:12 [PATCH] gnu: Add emacs-company Ricardo Wurmus
2016-06-17  6:20 ` Ben Woodcroft
2016-06-17  7:23   ` Ricardo Wurmus
2016-06-17 15:10     ` Ludovic Courtès
2016-06-17 19:19       ` Ricardo Wurmus

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).