* [PATCH] gnu: guile: Add "site-ccache" to the search path.
@ 2016-06-29 8:04 Alex Kost
2016-06-29 13:14 ` Ludovic Courtès
0 siblings, 1 reply; 6+ messages in thread
From: Alex Kost @ 2016-06-29 8:04 UTC (permalink / raw)
To: guix-devel
[-- Attachment #1: Type: text/plain, Size: 197 bytes --]
Add "site-ccache" since it's a directory where .go files of guile
packages should go (for example, 'guile-ssh' installs *.go there).
I suppose this patch should go to 'core-updates-next', right?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-guile-Add-site-ccache-to-the-search-path.patch --]
[-- Type: text/x-patch, Size: 1315 bytes --]
From 489a54be23753f61fa9c3a318d411eb48fb75bf6 Mon Sep 17 00:00:00 2001
From: Alex Kost <alezost@gmail.com>
Date: Wed, 29 Jun 2016 10:51:26 +0300
Subject: [PATCH] gnu: guile: Add "site-ccache" to the search path.
* gnu/packages/guile.scm (guile-2.0)[native-search-paths]: Add
"lib/guile/2.0/site-ccache" to GUILE_LOAD_COMPILED_PATH.
(guile-next): Likewise.
---
gnu/packages/guile.scm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/gnu/packages/guile.scm b/gnu/packages/guile.scm
index 2d8ca0c..5453e78 100644
--- a/gnu/packages/guile.scm
+++ b/gnu/packages/guile.scm
@@ -180,6 +180,7 @@ without requiring the source code to be rewritten.")
(search-path-specification
(variable "GUILE_LOAD_COMPILED_PATH")
(files '("lib/guile/2.0/ccache"
+ "lib/guile/2.0/site-ccache"
"share/guile/site/2.0")))))
(synopsis "Scheme implementation intended especially for extensions")
@@ -223,6 +224,7 @@ without requiring the source code to be rewritten.")
(search-path-specification
(variable "GUILE_LOAD_COMPILED_PATH")
(files '("lib/guile/2.2/ccache"
+ "lib/guile/2.2/site-ccache"
"share/guile/site/2.2")))))))
(define-public guile-for-guile-emacs
--
2.8.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] gnu: guile: Add "site-ccache" to the search path.
2016-06-29 8:04 [PATCH] gnu: guile: Add "site-ccache" to the search path Alex Kost
@ 2016-06-29 13:14 ` Ludovic Courtès
2016-06-29 14:00 ` Andy Wingo
0 siblings, 1 reply; 6+ messages in thread
From: Ludovic Courtès @ 2016-06-29 13:14 UTC (permalink / raw)
To: Alex Kost; +Cc: guix-devel
Alex Kost <alezost@gmail.com> skribis:
> Add "site-ccache" since it's a directory where .go files of guile
> packages should go (for example, 'guile-ssh' installs *.go there).
Indeed.
> I suppose this patch should go to 'core-updates-next', right?
Yes.
> From 489a54be23753f61fa9c3a318d411eb48fb75bf6 Mon Sep 17 00:00:00 2001
> From: Alex Kost <alezost@gmail.com>
> Date: Wed, 29 Jun 2016 10:51:26 +0300
> Subject: [PATCH] gnu: guile: Add "site-ccache" to the search path.
>
> * gnu/packages/guile.scm (guile-2.0)[native-search-paths]: Add
> "lib/guile/2.0/site-ccache" to GUILE_LOAD_COMPILED_PATH.
> (guile-next): Likewise.
[...]
> --- a/gnu/packages/guile.scm
> +++ b/gnu/packages/guile.scm
> @@ -180,6 +180,7 @@ without requiring the source code to be rewritten.")
> (search-path-specification
> (variable "GUILE_LOAD_COMPILED_PATH")
> (files '("lib/guile/2.0/ccache"
> + "lib/guile/2.0/site-ccache"
> "share/guile/site/2.0")))))
I wonder if it makes sense to keep lib/guile/2.0/ccache since that is
(meant to be) used exclusively by Guile itself, I think.
Andy, WDYT?
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] gnu: guile: Add "site-ccache" to the search path.
2016-06-29 13:14 ` Ludovic Courtès
@ 2016-06-29 14:00 ` Andy Wingo
2016-06-30 10:31 ` Ludovic Courtès
0 siblings, 1 reply; 6+ messages in thread
From: Andy Wingo @ 2016-06-29 14:00 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: guix-devel, Alex Kost
On Wed 29 Jun 2016 15:14, ludo@gnu.org (Ludovic Courtès) writes:
>> --- a/gnu/packages/guile.scm
>> +++ b/gnu/packages/guile.scm
>> @@ -180,6 +180,7 @@ without requiring the source code to be rewritten.")
>> (search-path-specification
>> (variable "GUILE_LOAD_COMPILED_PATH")
>> (files '("lib/guile/2.0/ccache"
>> + "lib/guile/2.0/site-ccache"
>> "share/guile/site/2.0")))))
>
> I wonder if it makes sense to keep lib/guile/2.0/ccache since that is
> (meant to be) used exclusively by Guile itself, I think.
>
> Andy, WDYT?
Removing Guile's own compiled paths from GUILE_LOAD_COMPILED_PATH sounds
like a good idea to me, since these are implicitly included via
GUILE_SYSTEM_COMPILED_PATH or whatever that is. Similarly for Scheme
files if that is possible!
Andy
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] gnu: guile: Add "site-ccache" to the search path.
2016-06-29 14:00 ` Andy Wingo
@ 2016-06-30 10:31 ` Ludovic Courtès
2016-06-30 14:18 ` Alex Kost
0 siblings, 1 reply; 6+ messages in thread
From: Ludovic Courtès @ 2016-06-30 10:31 UTC (permalink / raw)
To: Andy Wingo; +Cc: guix-devel, Alex Kost
Andy Wingo <wingo@igalia.com> skribis:
> On Wed 29 Jun 2016 15:14, ludo@gnu.org (Ludovic Courtès) writes:
>
>>> --- a/gnu/packages/guile.scm
>>> +++ b/gnu/packages/guile.scm
>>> @@ -180,6 +180,7 @@ without requiring the source code to be rewritten.")
>>> (search-path-specification
>>> (variable "GUILE_LOAD_COMPILED_PATH")
>>> (files '("lib/guile/2.0/ccache"
>>> + "lib/guile/2.0/site-ccache"
>>> "share/guile/site/2.0")))))
>>
>> I wonder if it makes sense to keep lib/guile/2.0/ccache since that is
>> (meant to be) used exclusively by Guile itself, I think.
>>
>> Andy, WDYT?
>
> Removing Guile's own compiled paths from GUILE_LOAD_COMPILED_PATH sounds
> like a good idea to me, since these are implicitly included via
> GUILE_SYSTEM_COMPILED_PATH or whatever that is.
OK. Alex, could you update the patch to not only add 2.x/site-ccache,
but also remove 2.x/ccache?
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] gnu: guile: Add "site-ccache" to the search path.
2016-06-30 10:31 ` Ludovic Courtès
@ 2016-06-30 14:18 ` Alex Kost
2016-06-30 21:14 ` Ludovic Courtès
0 siblings, 1 reply; 6+ messages in thread
From: Alex Kost @ 2016-06-30 14:18 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: guix-devel
Ludovic Courtès (2016-06-30 13:31 +0300) wrote:
> Andy Wingo <wingo@igalia.com> skribis:
>
>> On Wed 29 Jun 2016 15:14, ludo@gnu.org (Ludovic Courtès) writes:
>>
>>>> --- a/gnu/packages/guile.scm
>>>> +++ b/gnu/packages/guile.scm
>>>> @@ -180,6 +180,7 @@ without requiring the source code to be rewritten.")
>>>> (search-path-specification
>>>> (variable "GUILE_LOAD_COMPILED_PATH")
>>>> (files '("lib/guile/2.0/ccache"
>>>> + "lib/guile/2.0/site-ccache"
>>>> "share/guile/site/2.0")))))
>>>
>>> I wonder if it makes sense to keep lib/guile/2.0/ccache since that is
>>> (meant to be) used exclusively by Guile itself, I think.
>>>
>>> Andy, WDYT?
>>
>> Removing Guile's own compiled paths from GUILE_LOAD_COMPILED_PATH sounds
>> like a good idea to me, since these are implicitly included via
>> GUILE_SYSTEM_COMPILED_PATH or whatever that is.
>
> OK. Alex, could you update the patch to not only add 2.x/site-ccache,
> but also remove 2.x/ccache?
Done, committed to 'core-updates-next' as a08539dd1f.
... or did you mean to *send* the updated patch at first? oops :-)
--
Alex
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] gnu: guile: Add "site-ccache" to the search path.
2016-06-30 14:18 ` Alex Kost
@ 2016-06-30 21:14 ` Ludovic Courtès
0 siblings, 0 replies; 6+ messages in thread
From: Ludovic Courtès @ 2016-06-30 21:14 UTC (permalink / raw)
To: Alex Kost; +Cc: guix-devel
Alex Kost <alezost@gmail.com> skribis:
> Ludovic Courtès (2016-06-30 13:31 +0300) wrote:
>
>> Andy Wingo <wingo@igalia.com> skribis:
>>
>>> On Wed 29 Jun 2016 15:14, ludo@gnu.org (Ludovic Courtès) writes:
>>>
>>>>> --- a/gnu/packages/guile.scm
>>>>> +++ b/gnu/packages/guile.scm
>>>>> @@ -180,6 +180,7 @@ without requiring the source code to be rewritten.")
>>>>> (search-path-specification
>>>>> (variable "GUILE_LOAD_COMPILED_PATH")
>>>>> (files '("lib/guile/2.0/ccache"
>>>>> + "lib/guile/2.0/site-ccache"
>>>>> "share/guile/site/2.0")))))
>>>>
>>>> I wonder if it makes sense to keep lib/guile/2.0/ccache since that is
>>>> (meant to be) used exclusively by Guile itself, I think.
>>>>
>>>> Andy, WDYT?
>>>
>>> Removing Guile's own compiled paths from GUILE_LOAD_COMPILED_PATH sounds
>>> like a good idea to me, since these are implicitly included via
>>> GUILE_SYSTEM_COMPILED_PATH or whatever that is.
>>
>> OK. Alex, could you update the patch to not only add 2.x/site-ccache,
>> but also remove 2.x/ccache?
>
> Done, committed to 'core-updates-next' as a08539dd1f.
>
> ... or did you mean to *send* the updated patch at first? oops :-)
That’s fine. :-)
Thanks!
Ludo’.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-06-30 21:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-29 8:04 [PATCH] gnu: guile: Add "site-ccache" to the search path Alex Kost
2016-06-29 13:14 ` Ludovic Courtès
2016-06-29 14:00 ` Andy Wingo
2016-06-30 10:31 ` Ludovic Courtès
2016-06-30 14:18 ` Alex Kost
2016-06-30 21:14 ` Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).