From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 1/4] lint: Add packages with suffix ':bin' to
	'inputs-should-be-native'.
Date: Thu, 21 Jul 2016 18:06:32 +0200
Message-ID: <87poq7kmbb.fsf@gnu.org>
References: <20160719164916.6597-1-david@craven.ch>
	<20160719164916.6597-2-david@craven.ch> <87r3aobnoi.fsf@gnu.org>
	<CAL1_immZV=_J6ZmGqyUs5bP3x_f-weUvPp4E4unViTtZ0OwjdA@mail.gmail.com>
	<87y44vnpq3.fsf@gnu.org>
	<CAEwRq=oEkabsVRBuxYAHqd3AXBJ-bA_Wi-W1ebh1UCYb3OeFXw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38808)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bQGUh-0004Bi-QR
	for guix-devel@gnu.org; Thu, 21 Jul 2016 12:06:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bQGUc-0002Xo-PE
	for guix-devel@gnu.org; Thu, 21 Jul 2016 12:06:38 -0400
In-Reply-To: <CAEwRq=oEkabsVRBuxYAHqd3AXBJ-bA_Wi-W1ebh1UCYb3OeFXw@mail.gmail.com>
	(Vincent Legoll's message of "Thu, 21 Jul 2016 15:22:50 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Vincent Legoll <vincent.legoll@gmail.com>
Cc: guix-devel <guix-devel@gnu.org>, David Craven <david@craven.ch>

Vincent Legoll <vincent.legoll@gmail.com> skribis:

> On Thu, Jul 21, 2016 at 2:24 PM, Ludovic Court=C3=A8s <ludo@gnu.org> wrot=
e:
>> David Craven <david@craven.ch> skribis:
>>
>>>> I think packages with a =E2=80=9Cbin=E2=80=9D output are not always us=
ed as native
>>>> inputs, so I would drop this rule.
>>>
>>> From searching the code-base we have I couldn't find a counter example.=
 Do
>>> you think it's ok to check for glib:bin specifically?
>>
>> Yes, sounds good to me.
>>
>> However, make sure to match on the package name + output, not on the
>> label.  That is, =E2=80=98lint=E2=80=99 should correctly diagnose someth=
ing like:
>>
>>   (inputs `(("somethingsilly" ,glib "bin")))
>
> Yes, this is very important, as you have newbies coming now that try to
> package software for guix and they don't understand what they are doing.
>
> :-)
>
> I was wondering the other day, what this "somethingsilly" string is for,
> is it just a string or does it need to be a reference to something not si=
lly...

This "somethingsilly" is just a label that allows you to refer to an
input on the build side, in idioms like:

  (assoc-ref inputs "somethingsilly")
  =3D> "/gnu/store/=E2=80=A6-glib-42.0-bin"

This predates g-expressions, which solve this problem more elegantly.

Ludo=E2=80=99.