From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: [PATCH] gnu: sqlite: Enable DBSTAT_VTAB. Date: Thu, 01 Sep 2016 16:41:33 -0400 Message-ID: <87poonmjya.fsf@netris.org> References: <20160830233431.21109-1-david@craven.ch> <20160831185234.GC12396@jasmine> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37664) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bfYoN-0005mD-Ne for guix-devel@gnu.org; Thu, 01 Sep 2016 16:42:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bfYoH-0006sx-Na for guix-devel@gnu.org; Thu, 01 Sep 2016 16:42:10 -0400 Received: from world.peace.net ([50.252.239.5]:41031) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bfYoH-0006re-JB for guix-devel@gnu.org; Thu, 01 Sep 2016 16:42:05 -0400 In-Reply-To: <20160831185234.GC12396@jasmine> (Leo Famulari's message of "Wed, 31 Aug 2016 14:52:34 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org Leo Famulari writes: > On Wed, Aug 31, 2016 at 01:34:30AM +0200, David Craven wrote: >> * gnu/packages/databases.scm (sqlite)[arguments]: Enable configure-flag >> -DSQLITE_ENABLE_DBSTAT_VTAB. >> --- >> gnu/packages/databases.scm | 10 ++++++---- >> 1 file changed, 6 insertions(+), 4 deletions(-) >> >> diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm >> index a04c375..ce51d28 100644 >> --- a/gnu/packages/databases.scm >> +++ b/gnu/packages/databases.scm >> @@ -520,10 +520,12 @@ for example from a shell script.") >> (inputs `(("readline" ,readline))) >> (arguments >> `(#:configure-flags >> - ;; Add -DSQLITE_SECURE_DELETE and -DSQLITE_ENABLE_UNLOCK_NOTIFY to >> - ;; CFLAGS. GNU Icecat will refuse to use the system SQLite unless these >> - ;; options are enabled. >> - '("CFLAGS=-O2 -DSQLITE_SECURE_DELETE -DSQLITE_ENABLE_UNLOCK_NOTIFY"))) >> + ;; Add -DSQLITE_SECURE_DELETE, -DSQLITE_ENABLE_UNLOCK_NOTIFY and >> + ;; -DSQLITE_ENABLE_DBSTAT_VTAB to CFLAGS. GNU Icecat will refuse >> + ;; to use the system SQLite unless these options are enabled. >> + (list (string-append "CFLAGS=-O2 -DSQLITE_SECURE_DELETE " >> + "-DSQLITE_ENABLE_UNLOCK_NOTIFY " >> + "-DSQLITE_ENABLE_DBSTAT_VTAB")))) > > When the new Icecat is released, I think we should graft this change > onto the master branch. This is because the new Icecat will fix a bunch > of security bugs. I don't think grafting this will help, because IceCat will refuse to use sqlite without the needed options at build time, when it sees the original (ungrafted) version of sqlite. Anyway, we should push this to core-updates. David, would you like to do that? Thanks, Mark