From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kei Kebreau Subject: Re: [PATCH] gnu: Add gnome-calculator. Date: Sat, 24 Sep 2016 10:54:49 -0400 Message-ID: <87pontmjpi.fsf@openmailbox.org> References: <601048019f29fb5815582f203f6684b7@openmailbox.org> <874m57xvce.fsf@openmailbox.org> <1474636075.7646.7.camel@openmailbox.org> <87intm7fka.fsf@openmailbox.org> <87h996t275.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:38698) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnoMC-0003Eu-4X for guix-devel@gnu.org; Sat, 24 Sep 2016 10:55:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bnoM9-00058f-2X for guix-devel@gnu.org; Sat, 24 Sep 2016 10:55:12 -0400 Received: from smtp25.openmailbox.org ([62.4.1.59]:58723 helo=smtp10.openmailbox.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnoM8-000575-Sr for guix-devel@gnu.org; Sat, 24 Sep 2016 10:55:09 -0400 In-Reply-To: <87h996t275.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sat, 24 Sep 2016 12:18:54 +0900") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org, rennes --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Hello, > > Kei Kebreau skribis: > >> rennes writes: >> >>> On Thu, 2016-09-22 at 21:23 -0400, Kei Kebreau wrote: >>>>=20 >>>> This is a good patch! The only change I recommend is moving the >>>> defintion to gnome.scm. >>> >>> I update the patch, >>> =C2=A0* Create the definition in gnome.scm file. >>> =C2=A0* Move 'glib' to=C2=A0native-inputs. >>> =C2=A0* Delete Copyright duplicate for=C2=A0 >>> =C2=A0 =C2=A0';;; Copyright =C2=A9 2016 Rene Saavedra ' >>> >>> Thank you >> >> Looks good and works well. >> >> Does somebody want to commit this to master? >> I'd do it myself, but I'm unfamiliar with the process of commiting >> someone else's code and I don't want to break anything. > > It=E2=80=99s a good occasion to try=E2=80=94we need more reviewers! :-) > > The process is essentially to pipe the patch (which includes the commit > log and Subject: line) through =E2=80=9Cgit am -s=E2=80=9D. > > If that applies fine, just run =E2=80=98guix lint the-package=E2=80=99 an= d ideally =E2=80=98guix > build --rounds=3D2 the-package=E2=80=99 to catch any issues. > > If nothing comes up, just push! > > If minor issues (typos, synopsis, etc.) come up, you might commit them > on behalf of the author, or ask them what they prefer. > > Could you try and report back? :-) > > Thanks Kei & rennes! > > Ludo=E2=80=99. I've already pushed it! I guess my last message only went back to Leo. Thank you and Leo for your help. :-) rennes, everything looked good. Thanks for your contribution! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJX5pO6AAoJEOal7jwZRnoNLJEP/1kRSSAX+I/vZcMtI8/khqtW O3YdJPoAu8oBGH1aPCJs6HdyqGUGktKYeLGfn66IzIJ9GbLKgFmAZ70OPNcOkOK8 7h1W+hqipDO5aX4N4dAumw3AEwU3O+c+aE8Y9Z46eDijZJZ8ozJUQKKboOPc37Xn 8Bnx64ceBtnnjXqwkWVsUFBAVfSi3+xg8Gh6dhbLsa60W9yu+gL9SG4fU1rDrNn3 xyZS+0/jiRr51plgT04W399X6G0Ban0in0Rlv1G2p9Rer6FOcdK+peYbAFFlzBHe 531hM/SXQw83/scEAUcUR8jDsVO5hjq509QOGmQFxRN7dtP0HO8+hovsrEZneqhR rrOgjHEesFRMcNNcXMFzOakGnQh+jG/VOwRyx79Uh8pXZRLPeJ5VD9OYsE+EuCSW aV/JYaR9UJbClvMq1pitnfLuET1sYt8snfyq3gunmP7tcE1hyTGGXD8MnVRJDViq DuyUTU4P3zenafvSO3Bad2/dDpQD26Sis6cqUNrV7uFn7oBVqgSl0RXqx3A9EQr+ p2T5oXZutB15H7fcb/33L55d+ZLUFKHcL5i8i+xOvZInDFnET/QguFN8nMN1NamG ZL2vN1QaCuBTJHc+28PvRiPRrG2Dx/1txcrvv0CjgxG3lcmJXgWwx6liSc/kfWGl OAiUP6ggaRFV+7dYuEO8 =OdPO -----END PGP SIGNATURE----- --=-=-=--