From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH] gnu: Add nethogs. Date: Sun, 30 Oct 2016 12:18:32 +0000 Message-ID: <87pomirpwn.fsf@duckhunt.i-did-not-set--mail-host-address--so-tickle-me> References: <20161030071645.5634-1-arunisaac@systemreboot.net> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56065) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c0p4S-0000RS-DK for guix-devel@gnu.org; Sun, 30 Oct 2016 08:18:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c0p4P-00061V-AA for guix-devel@gnu.org; Sun, 30 Oct 2016 08:18:40 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:54649) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c0p4P-00061P-3l for guix-devel@gnu.org; Sun, 30 Oct 2016 08:18:37 -0400 In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Arun Isaac , guix-devel@gnu.org --=-=-= Content-Type: text/plain Arun Isaac writes: > Arun Isaac writes: > >> + (arguments >> + `(#:make-flags `("CC=gcc" >> + ,(string-append "PREFIX=" %output)) >> + #:phases >> + (modify-phases %standard-phases >> + (delete 'configure)))) > > Currently, the nethogs binary goes to /sbin. Should I make it go to > /bin? I'll have to run substitute* on src/MakeApp.mk for that. I am in favor of this. Maybe in the long run we can restore sbin to its former glory, that is static binaries ;) Other than that this package looks great. I'm not sure how bash knows to tab-complete my network interfaces, but I'm not complaining! :) One minor suggestion, feel free to disregard this: Perhaps synopsis could be "Per-process bandwidth monitor" and then "for Linux" added to the first sentence of the description. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBCgAGBQJYFeUYAAoJEKKgbfKjOlT6o44IAJdzVTC9o5NsTQ9JW9NHoTj3 7WU4oWZETFuUz5JnrjXWjWiK7b+4GNdJCeuBajxnpx1SujSRoC5XYcGpTrSPLYKE Dy1RUE/5Uwdz30YZjDHAMqQRhWuasllYf8Kh5R5gb6PLpEjp0+7My2SUJSU5KKqg Jmoq8AVfKXMDHtRVNeiOAAO3a0qo6fQw69NLrHZia+PCLrma+WyYXgLKrj9IF6M3 z7xY2y8ndWTdtS/e+nuspgYE6K0BxVv1ByRfKee9+cwMZAh0NBzB4Nm6q60izLc2 wcYtd4m8omzQgpxQfd8uo4/whrc+FxAadXr1u9EXJluQUvm8AEU1XGdqjW9OqVU= =Htsp -----END PGP SIGNATURE----- --=-=-=--