From: Marius Bakke <mbakke@fastmail.com>
To: Arun Isaac <arunisaac@systemreboot.net>, guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add nethogs.
Date: Sun, 30 Oct 2016 12:18:32 +0000 [thread overview]
Message-ID: <87pomirpwn.fsf@duckhunt.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <cu77f8qwb48.fsf@systemreboot.net>
[-- Attachment #1: Type: text/plain, Size: 855 bytes --]
Arun Isaac <arunisaac@systemreboot.net> writes:
> Arun Isaac writes:
>
>> + (arguments
>> + `(#:make-flags `("CC=gcc"
>> + ,(string-append "PREFIX=" %output))
>> + #:phases
>> + (modify-phases %standard-phases
>> + (delete 'configure))))
>
> Currently, the nethogs binary goes to /sbin. Should I make it go to
> /bin? I'll have to run substitute* on src/MakeApp.mk for that.
I am in favor of this. Maybe in the long run we can restore sbin to its
former glory, that is static binaries ;)
Other than that this package looks great. I'm not sure how bash knows to
tab-complete my network interfaces, but I'm not complaining! :)
One minor suggestion, feel free to disregard this: Perhaps synopsis
could be "Per-process bandwidth monitor" and then "for Linux" added to
the first sentence of the description.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]
next prev parent reply other threads:[~2016-10-30 12:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-30 7:16 [PATCH] gnu: Add nethogs Arun Isaac
2016-10-30 7:26 ` Arun Isaac
2016-10-30 12:18 ` Marius Bakke [this message]
2016-10-30 13:40 ` Alex Kost
2016-10-30 16:44 ` Arun Isaac
2016-10-30 17:04 ` Arun Isaac
2016-10-30 17:09 ` Leo Famulari
2016-10-30 17:46 ` Arun Isaac
2016-10-30 19:41 ` Leo Famulari
2016-10-31 6:00 ` Arun Isaac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pomirpwn.fsf@duckhunt.i-did-not-set--mail-host-address--so-tickle-me \
--to=mbakke@fastmail.com \
--cc=arunisaac@systemreboot.net \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).