[PATCH] Add perl-digest-md5.

[PATCH] Add perl-digest-md5.

[ng0]

[PATCH] gnu: Add perl-digest-md5.

This adds perl-digest-md5, in web.scm as perl-digest-md5-file is located there.

[PATCH] gnu: Add perl-digest-md5.

[ng0]

From: ng0 <ng0@libertad.pw>

* gnu/packages/web.scm (perl-digest-md5): New variable.
---
 gnu/packages/web.scm | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
index 063a8a9..5f8eefe 100644
--- a/gnu/packages/web.scm
+++ b/gnu/packages/web.scm
@@ -13,7 +13,7 @@
 ;;; Copyright © 2016 Rene Saavedra <rennes@openmailbox.org>
 ;;; Copyright © 2016 Ben Woodcroft <donttrustben@gmail.com>
 ;;; Copyright © 2016 Clément Lassieur <clement@lassieur.org>
-;;; Copyright © 2016 ng0 <ng0@we.make.ritual.n0.is>
+;;; Copyright © 2016 ng0 <ng0@libertad.pw>
 ;;; Copyright © 2016 Arun Isaac <arunisaac@systemreboot.net>
 ;;; Copyright © 2016 Tobias Geerinckx-Rice <me@tobias.gr>
 ;;;
@@ -1745,6 +1745,28 @@ inputs, in a manner reminiscent of how PHP does.")
 formats used by the HTTP protocol.")
     (license (package-license perl))))
 
+(define-public perl-digest-md5
+  (package
+    (name "perl-digest-md5")
+    (version "2.55")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://cpan/authors/id/G/GA/GAAS/Digest-MD5-"
+                           version ".tar.gz"))
+       (sha256
+        (base32
+         "0g0fklbrm2krswc1xhp4iwn1dhqq71fqh2p5wm8xj9a4s6i9ic83"))))
+    (build-system perl-build-system)
+    (home-page "http://search.cpan.org/dist/Digest-MD5")
+    (synopsis "Perl interface to the MD-5 algorithm")
+    (description
+     "The @code{Digest::MD5} module allows you to use the MD5 Message Digest
+algorithm from within Perl programs.  The algorithm takes as
+input a message of arbitrary length and produces as output a
+128-bit \"fingerprint\" or \"message digest\" of the input.")
+    (license (package-license perl))))
+
 (define-public perl-digest-md5-file
   (package
     (name "perl-digest-md5-file")
-- 
2.10.2

Re: [PATCH] Add perl-digest-md5.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 463 bytes --]

ng0 <ng0@we.make.ritual.n0.is> writes:

> [PATCH] gnu: Add perl-digest-md5.
>
> This adds perl-digest-md5, in web.scm as perl-digest-md5-file is located there.

Hi! The patch looks good, but I think it should go in perl.scm. The
rationale for adding perl-digest-md5-file in web.scm seems to be that
it's a module for checksumming URIs, whereas this is a general-purpose
checksum program similar to e.g. 'perl-digest-sha1'.

Can you send an updated patch? Thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]

perl-digest-md5 , rev2

[ng0]

rev2 for patch, moved to perl.scm

[PATCH] gnu: Add perl-digest-md5.

[ng0]

From: ng0 <ng0@libertad.pw>

* gnu/packages/perl.scm (perl-digest-md5): New variable.
---
 gnu/packages/perl.scm | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index ab61201..031353d 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -7,7 +7,7 @@
 ;;; Copyright © 2016 Mark H Weaver <mhw@netris.org>
 ;;; Copyright © 2016 Jochem Raat <jchmrt@riseup.net>
 ;;; Copyright © 2016 Efraim Flashner <efraim@flashner.co.il>
-;;; Coypright © 2016 ng0 <ng0@we.make.ritual.n0.is>
+;;; Coypright © 2016 ng0 <ng0@libertad.pw>
 ;;; Copyright © 2016 Alex Sassmannshausen <alex@pompo.co>
 ;;; Copyright © 2016 Roel Janssen <roel@gnu.org>
 ;;; Copyright © 2016 Ben Woodcroft <donttrustben@gmail.com>
@@ -2055,6 +2055,28 @@ each stack frame.")
 interface for the RFC 2104 HMAC mechanism.")
     (license (package-license perl))))
 
+(define-public perl-digest-md5
+  (package
+    (name "perl-digest-md5")
+    (version "2.55")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://cpan/authors/id/G/GA/GAAS/Digest-MD5-"
+                           version ".tar.gz"))
+       (sha256
+        (base32
+         "0g0fklbrm2krswc1xhp4iwn1dhqq71fqh2p5wm8xj9a4s6i9ic83"))))
+    (build-system perl-build-system)
+    (home-page "http://search.cpan.org/dist/Digest-MD5")
+    (synopsis "Perl interface to the MD-5 algorithm")
+    (description
+     "The @code{Digest::MD5} module allows you to use the MD5 Message Digest
+algorithm from within Perl programs.  The algorithm takes as
+input a message of arbitrary length and produces as output a
+128-bit \"fingerprint\" or \"message digest\" of the input.")
+    (license (package-license perl))))
+
 (define-public perl-digest-sha1
   (package
     (name "perl-digest-sha1")
-- 
2.10.2

Re: perl-digest-md5 , rev2

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 390 bytes --]

ng0 <ng0@we.make.ritual.n0.is> writes:

> rev2 for patch, moved to perl.scm

Thanks, applied!

I noticed the 'strip' phase was unable to strip MD5.so because of
permissions, so I added a phase to chmod it 755.

The build is still not reproducible however, it seems the build time is
recorded in "perllocal.pod". This is not unique for this package and
should be fixed in perl-build-system.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 483 bytes --]

Re: perl-digest-md5 , rev2

[ng0]

Marius Bakke <mbakke@fastmail.com> writes:

> ng0 <ng0@we.make.ritual.n0.is> writes:
>
>> rev2 for patch, moved to perl.scm
>
> Thanks, applied!
>
> I noticed the 'strip' phase was unable to strip MD5.so because of
> permissions, so I added a phase to chmod it 755.

Thanks!

> The build is still not reproducible however, it seems the build time is
> recorded in "perllocal.pod". This is not unique for this package and
> should be fixed in perl-build-system.

1) Is there a bug for this filed? If not, can you open one?

2) And as one project I work in provides perl software, which might
or might not stick around in the future, do you know how this
(perl records build time) can be fixed for systems which are not
Guix? Upstream, in perl? Are they aware of this and has this been
un/succesfully be communicated before?
-- 
♥Ⓐ  ng0  | ng0.chaosnet.org

Re: perl-digest-md5 , rev2

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1200 bytes --]

ng0 <ng0@libertad.pw> writes:

> Marius Bakke <mbakke@fastmail.com> writes:
>
>> ng0 <ng0@we.make.ritual.n0.is> writes:
>>
>>> rev2 for patch, moved to perl.scm
>>
>> Thanks, applied!
>>
>> I noticed the 'strip' phase was unable to strip MD5.so because of
>> permissions, so I added a phase to chmod it 755.
>
> Thanks!
>
>> The build is still not reproducible however, it seems the build time is
>> recorded in "perllocal.pod". This is not unique for this package and
>> should be fixed in perl-build-system.
>
> 1) Is there a bug for this filed? If not, can you open one?
>
> 2) And as one project I work in provides perl software, which might
> or might not stick around in the future, do you know how this
> (perl records build time) can be fixed for systems which are not
> Guix? Upstream, in perl? Are they aware of this and has this been
> un/succesfully be communicated before?

I actually started working on this. One workaround is to call `make
pure_inst_perl` per http://perldoc.perl.org/ExtUtils/MakeMaker.html .

Another approach is to simply delete it, as per the Arch perl packaging
guidelines: https://wiki.archlinux.org/index.php/Perl_Package_Guidelines

Expect a patch later today!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

Re: perl-digest-md5 , rev2

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 810 bytes --]

Marius Bakke <mbakke@fastmail.com> writes:

> I noticed the 'strip' phase was unable to strip MD5.so because of
> permissions, so I added a phase to chmod it 755.

I'm really sorry for the git noise regarding this package. Apparently
it's made read-only during the install phase, so the 'set-permissions'
phase has no effect.

I have a commit that fixes it, but upon further investigation this seems
to be the case for most/all perl packages. Only one other perl package
has a custom phase to fix it currently. Perhaps we should change
'perl-build-system' to make all .so files writable as well?

Alternatively, do it in 'gnu-build-system', as there are non-perl
packages with custom phases to make '.so' files writable as well. 

Perhaps simply run a 'chmod 755' in the 'strip' phase? WDYT?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]